feat: add bundle for windows #1575
Conversation
Walkthrough此次更改主要涉及在 GitHub Actions 工作流中新增针对 Windows 环境的构建配置，支持 Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/node-bind-build.yml (1 hunks)
- packages/mako/package.json (1 hunks)
Additional comments not posted (2)
packages/mako/package.json (1)
17-19: 新增架构支持代码正确地在
napi配置中添加了新的目标架构"i686-pc-windows-msvc"和"x86_64-pc-windows-msvc"。这些更改与 PR 目标一致，扩展了包在 Windows 环境中的兼容性。.github/workflows/node-bind-build.yml (1)
68-79: 新增 Windows 构建配置代码正确地在 GitHub Actions 工作流中添加了针对
x86_64-pc-windows-msvc和i686-pc-windows-msvc的新构建配置。这些更改扩展了项目在多个 Windows 架构上的构建能力，提高了兼容性和部署选项。
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1575 +/- ##
=======================================
Coverage 62.00% 62.00%
=======================================
Files 127 127
Lines 15344 15344
=======================================
Hits 9514 9514
Misses 5830 5830 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (10)
- packages/bundler-mako/package.json (1 hunks)
- packages/mako/npm/darwin-arm64/package.json (1 hunks)
- packages/mako/npm/darwin-x64/package.json (1 hunks)
- packages/mako/npm/linux-arm64-gnu/package.json (2 hunks)
- packages/mako/npm/linux-arm64-musl/package.json (1 hunks)
- packages/mako/npm/linux-x64-gnu/package.json (1 hunks)
- packages/mako/npm/linux-x64-musl/package.json (1 hunks)
- packages/mako/npm/win32-ia32-msvc/package.json (2 hunks)
- packages/mako/npm/win32-x64-msvc/package.json (2 hunks)
- packages/mako/package.json (3 hunks)
Files skipped from review due to trivial changes (4)
- packages/mako/npm/darwin-arm64/package.json
- packages/mako/npm/darwin-x64/package.json
- packages/mako/npm/linux-x64-gnu/package.json
- packages/mako/npm/win32-ia32-msvc/package.json
Additional comments not posted (6)
packages/mako/npm/win32-x64-msvc/package.json (1)
3-3: 版本更新审查通过。版本从
0.0.0更新到0.8.9-canary.20240906.1，适合于重大更新或添加的情况。使用 "canary" 标签对于正在进行的功能是恰当的，允许在稳定版本发布前进行测试。packages/mako/npm/linux-x64-musl/package.json (1)
3-3: 版本更新审查通过。版本从
0.8.8更新到0.8.9-canary.20240906.1，适合于重大更新或添加的情况。使用 "canary" 标签对于正在进行的功能是恰当的，允许在稳定版本发布前进行测试。packages/mako/npm/linux-arm64-musl/package.json (1)
3-3: 版本更新审查通过。版本从
0.8.8更新到0.8.9-canary.20240906.1，适合于重大更新或添加的情况。使用 "canary" 标签对于正在进行的功能是恰当的，允许在稳定版本发布前进行测试。packages/mako/npm/linux-arm64-gnu/package.json (1)
3-3: 版本更新审查此次更改将版本号从
0.0.0更新至0.8.9-canary.20240906.1。请确保此版本与 Linux ARM64 架构的兼容性。packages/bundler-mako/package.json (1)
3-3: 版本及依赖更新审查此次更改将
@umijs/bundler-mako的版本号从0.8.8更新至0.8.9-canary.20240906.1，并更新了对@umijs/mako的依赖版本。请确保这些更新不会影响现有功能，并与其他依赖项保持兼容。Also applies to: 6-6
packages/mako/package.json (1)
3-3: 版本更新及架构扩展审查此次更改更新了版本号至
0.8.9-canary.20240906.1，并新增了对 Windows 环境的支持（i686-pc-windows-msvc和x86_64-pc-windows-msvc）。此外，更新了可选依赖项以反映新版本。请确保在 Windows 平台上进行彻底测试，以验证新架构的兼容性和功能。Also applies to: 17-19, 80-87
sorrycc
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (11)
- packages/bundler-mako/package.json (1 hunks)
- packages/mako/npm/darwin-arm64/package.json (1 hunks)
- packages/mako/npm/darwin-x64/package.json (1 hunks)
- packages/mako/npm/linux-arm64-gnu/package.json (2 hunks)
- packages/mako/npm/linux-arm64-musl/package.json (1 hunks)
- packages/mako/npm/linux-x64-gnu/package.json (1 hunks)
- packages/mako/npm/linux-x64-musl/package.json (1 hunks)
- packages/mako/npm/win32-ia32-msvc/package.json (2 hunks)
- packages/mako/npm/win32-x64-msvc/package.json (2 hunks)
- packages/mako/package.json (3 hunks)
- packages/mako/src/cli.ts (1 hunks)
Files skipped from review as they are similar to previous changes (10)
- packages/bundler-mako/package.json
- packages/mako/npm/darwin-arm64/package.json
- packages/mako/npm/darwin-x64/package.json
- packages/mako/npm/linux-arm64-gnu/package.json
- packages/mako/npm/linux-arm64-musl/package.json
- packages/mako/npm/linux-x64-gnu/package.json
- packages/mako/npm/linux-x64-musl/package.json
- packages/mako/npm/win32-ia32-msvc/package.json
- packages/mako/npm/win32-x64-msvc/package.json
- packages/mako/package.json
Additional comments not posted (3)
packages/mako/src/cli.ts (3)
Line range hint
41-53: 帮助功能实现正确
showHelp函数提供了 CLI 的帮助信息，实现看起来没有问题。
Line range hint
55-67: 构建帮助功能实现正确
showBuildHelp函数为构建命令提供了帮助信息，实现看起来没有问题。
Line range hint
1-39: 移除 Windows 平台的错误处理逻辑根据 AI 生成的摘要，此次更改移除了针对 Windows 平台的错误处理逻辑。这可能会导致 Windows 用户在使用 CLI 时遇到未处理的错误。建议进行彻底的测试，以确保在 Windows 上的兼容性和稳定性。
请运行以下脚本来验证 Windows 平台上的行为：
Close #1480
参考：
#1508
Summary by CodeRabbit
Summary by CodeRabbit