Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build all platform by ci #1508

Closed
wants to merge 6 commits into from
Closed

Conversation

xiaohuoni
Copy link
Member

@xiaohuoni xiaohuoni commented Aug 20, 2024

主要是支持 window

触发条件改成提交日志是 "release:"

如果能正确发包的话,可以 Close: #1343

fork 的仓库,可以看到有对应包生成,发包都走通了,(发了别名包测试)https://www.npmjs.com/package/@alita/mako-win32-x64-msvc?activeTab=code
image

Summary by CodeRabbit

Summary by CodeRabbit

  • 新特性

    • 更新应用名称为“mako”,并增强跨平台构建流程,现支持Windows平台(i686和x86_64架构)。
  • 修复

    • 修正了构建过程中包路径的错误,确保文件管理的准确性。

Copy link
Contributor

coderabbitai bot commented Aug 20, 2024

## Walkthrough

此次更改主要涉及 `node-bind-build` 工作流的配置更新,应用名称从 `okam` 修改为 `mako`,并对多平台构建流程进行了调整。构建命令和存储路径进行了相应修改,增加了对 Windows 平台的支持,确保了跨平台构建能力的提升。

## Changes

| 文件                                     | 修改摘要                                                                                      |
|----------------------------------------|-------------------------------------------------------------------------------------------|
| `.github/workflows/node-bind-build.yml` | 应用名称从 `okam` 更改为 `mako`;更新构建命令,调整触发条件并修正路径错误;增加 Windows 支持。                     |
| `packages/mako/package.json`           | 添加对 `i686-pc-windows-msvc``x86_64-pc-windows-msvc` 平台的支持。                                   |

## Assessment against linked issues

| Objective                                  | Addressed | Explanation                 |
|--------------------------------------------|-----------|-----------------------------|
| 支持在 Windows 上构建 (1343)               ||                             |

> 在兔子的舞台上,  
> 新应用名在欢笑中,  
> 构建跨平台更轻松,  
> 兔子跳跃过,心情好,  
> Mako耀眼如星光,  
> 趣味无穷乐无量。 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4e8892e and 425b47a.

Files selected for processing (1)
  • .github/workflows/node-bind-build.yml (6 hunks)
Additional comments not posted (11)
.github/workflows/node-bind-build.yml (11)

4-4: 更改应用名称为 mako

这个更改符合更新应用名称的目标。


23-23: 更新发布条件的逻辑。

将条件从 contains 更改为 startsWith,以便更精确地触发发布相关的作业。


49-49: 更新构建命令以使用新的应用名称。

构建命令已更新为使用 @umijs/mako,这与应用名称的更改保持一致。


57-57: 更新构建命令以使用新的应用名称。

构建命令已更新为使用 @umijs/mako,这与应用名称的更改保持一致。


63-63: 更新构建命令以使用新的应用名称。

构建命令已更新为使用 @umijs/mako,这与应用名称的更改保持一致。


67-69: 添加 Windows 平台支持。

增加了 Windows 平台的构建步骤,这对于实现跨平台支持至关重要。


73-74: 添加 Windows 平台支持。

增加了 Windows 平台的构建步骤,这对于实现跨平台支持至关重要。


142-142: 修正路径拼写错误。

将路径从 packaegs 更正为 packages,确保文件管理正确。


167-167: 修正路径拼写错误。

将路径从 packaegs 更正为 packages,确保文件管理正确。


169-169: 更新构建命令以使用新的应用名称。

构建命令已更新为使用 @umijs/mako,这与应用名称的更改保持一致。


171-171: 修正路径拼写错误。

将路径从 packaegs 更正为 packages,确保文件管理正确。

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 425b47a and 30c47dc.

Files selected for processing (1)
  • .github/workflows/node-bind-build.yml (6 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/node-bind-build.yml

@xiaohuoni xiaohuoni changed the title feat: build all platform by ci [WIP]feat: build all platform by ci Aug 20, 2024
@xiaohuoni xiaohuoni changed the title [WIP]feat: build all platform by ci feat: build all platform by ci Aug 20, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 30c47dc and 226b81d.

Files selected for processing (2)
  • .github/workflows/node-bind-build.yml (6 hunks)
  • packages/mako/package.json (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/node-bind-build.yml
Additional comments not posted (2)
packages/mako/package.json (2)

15-15: 新增对32位Windows平台的支持。

添加了对i686-pc-windows-msvc的支持,这将增强在32位Windows系统上的兼容性。


17-17: 新增对64位Windows平台的支持。

添加了对x86_64-pc-windows-msvc的支持,这将增强在64位Windows系统上的兼容性。

@xiaohuoni xiaohuoni closed this Aug 29, 2024
@xiaohuoni xiaohuoni deleted the feat-build-all-platform-by-ci branch August 29, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is not supported on Windows yet
1 participant