-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build all platform by ci #1508
Conversation
## Walkthrough
此次更改主要涉及 `node-bind-build` 工作流的配置更新,应用名称从 `okam` 修改为 `mako`,并对多平台构建流程进行了调整。构建命令和存储路径进行了相应修改,增加了对 Windows 平台的支持,确保了跨平台构建能力的提升。
## Changes
| 文件 | 修改摘要 |
|----------------------------------------|-------------------------------------------------------------------------------------------|
| `.github/workflows/node-bind-build.yml` | 应用名称从 `okam` 更改为 `mako`;更新构建命令,调整触发条件并修正路径错误;增加 Windows 支持。 |
| `packages/mako/package.json` | 添加对 `i686-pc-windows-msvc` 和 `x86_64-pc-windows-msvc` 平台的支持。 |
## Assessment against linked issues
| Objective | Addressed | Explanation |
|--------------------------------------------|-----------|-----------------------------|
| 支持在 Windows 上构建 (1343) | ✅ | |
> 在兔子的舞台上,
> 新应用名在欢笑中,
> 构建跨平台更轻松,
> 兔子跳跃过,心情好,
> Mako耀眼如星光,
> 趣味无穷乐无量。 🐇✨ Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/node-bind-build.yml (6 hunks)
Additional comments not posted (11)
.github/workflows/node-bind-build.yml (11)
4-4
: 更改应用名称为mako
。这个更改符合更新应用名称的目标。
23-23
: 更新发布条件的逻辑。将条件从
contains
更改为startsWith
,以便更精确地触发发布相关的作业。
49-49
: 更新构建命令以使用新的应用名称。构建命令已更新为使用
@umijs/mako
,这与应用名称的更改保持一致。
57-57
: 更新构建命令以使用新的应用名称。构建命令已更新为使用
@umijs/mako
,这与应用名称的更改保持一致。
63-63
: 更新构建命令以使用新的应用名称。构建命令已更新为使用
@umijs/mako
,这与应用名称的更改保持一致。
67-69
: 添加 Windows 平台支持。增加了 Windows 平台的构建步骤,这对于实现跨平台支持至关重要。
73-74
: 添加 Windows 平台支持。增加了 Windows 平台的构建步骤,这对于实现跨平台支持至关重要。
142-142
: 修正路径拼写错误。将路径从
packaegs
更正为packages
,确保文件管理正确。
167-167
: 修正路径拼写错误。将路径从
packaegs
更正为packages
,确保文件管理正确。
169-169
: 更新构建命令以使用新的应用名称。构建命令已更新为使用
@umijs/mako
,这与应用名称的更改保持一致。
171-171
: 修正路径拼写错误。将路径从
packaegs
更正为packages
,确保文件管理正确。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/node-bind-build.yml (6 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/node-bind-build.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/node-bind-build.yml (6 hunks)
- packages/mako/package.json (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/node-bind-build.yml
Additional comments not posted (2)
packages/mako/package.json (2)
15-15
: 新增对32位Windows平台的支持。添加了对
i686-pc-windows-msvc
的支持,这将增强在32位Windows系统上的兼容性。
17-17
: 新增对64位Windows平台的支持。添加了对
x86_64-pc-windows-msvc
的支持,这将增强在64位Windows系统上的兼容性。
主要是支持 window
触发条件改成提交日志是 "release:"
如果能正确发包的话,可以 Close: #1343
在 fork 的仓库,可以看到有对应包生成,发包都走通了,(发了别名包测试)https://www.npmjs.com/package/@alita/mako-win32-x64-msvc?activeTab=code
Summary by CodeRabbit
Summary by CodeRabbit
新特性
修复