-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: css order lost after chunk dependencies sorted by alphabet #1391
Conversation
Walkthrough
Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- crates/mako/src/generate/chunk_graph.rs (1 hunks)
Additional comments not posted (1)
crates/mako/src/generate/chunk_graph.rs (1)
114-118
: 验证更改后的顺序影响删除排序步骤简化了逻辑,但可能影响返回的
chunk_ids
的顺序。请确保这种顺序变化不会影响系统的其他部分。
As the title described. Should revert #1117 and re-open #1116
Summary by CodeRabbit
sync_dependencies_chunk
方法,取消了返回之前对chunk_ids
的排序。提高了性能表现。