Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: css order lost after chunk dependencies sorted by alphabet #1391

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

xusd320
Copy link
Contributor

@xusd320 xusd320 commented Jul 9, 2024

As the title described. Should revert #1117 and re-open #1116

Summary by CodeRabbit

  • 优化
    • 修改了 sync_dependencies_chunk 方法,取消了返回之前对 chunk_ids 的排序。提高了性能表现。

Copy link
Contributor

coderabbitai bot commented Jul 9, 2024

Walkthrough

ChunkGraphsync_dependencies_chunk 方法进行了修改,不再对返回的 chunk_ids 进行排序。这一变化简化了代码,可能对依赖项的顺序有不同需求的场景下更为灵活。

Changes

文件路径 修改摘要
crates/mako/src/generate/chunk_graph.rs 修改 sync_dependencies_chunk 方法,移除返回前的排序操作

Poem

错综依赖图中游,
兔子心头喜悠悠。
疏通排序刀锋匿,
代码更显轻松秀。
依赖顺序由你定,
圈圈跳跃乐无忧。
🌸🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1396db8 and e8eedf6.

Files selected for processing (1)
  • crates/mako/src/generate/chunk_graph.rs (1 hunks)
Additional comments not posted (1)
crates/mako/src/generate/chunk_graph.rs (1)

114-118: 验证更改后的顺序影响

删除排序步骤简化了逻辑,但可能影响返回的 chunk_ids 的顺序。请确保这种顺序变化不会影响系统的其他部分。

@xusd320 xusd320 merged commit 67c1340 into master Jul 10, 2024
8 checks passed
@sorrycc sorrycc deleted the fix/css-order branch July 10, 2024 00:39
@xusd320 xusd320 restored the fix/css-order branch July 10, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants