Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 sort dependence chunk id #1117

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

stormslowly
Copy link
Member

@stormslowly stormslowly commented May 6, 2024

close #1116

Summary by CodeRabbit

  • Bug Fixes
    • ChunkGraph结构体的chunk_graph.rs文件中的sync_dependencies_chunk方法中,现在在返回之前对chunk_ids向量进行了排序操作。

Copy link
Contributor

coderabbitai bot commented May 6, 2024

概览

这次更新涉及对整体的高层次更改,而不是特定文件。在ChunkGraph结构体的chunk_graph.rs文件中的sync_dependencies_chunk方法中,添加了对chunk_ids向量进行排序的操作。

变更

文件路径 变更摘要
crates/mako/src/generate/chunk_graph.rs ChunkGraph结构体的sync_dependencies_chunk方法中,添加了对chunk_ids向量进行排序的操作。
biome.json biome.json文件中的exclude部分,新增了./.pnpm-store/**排除模式,与现有的./tmp/**排除模式并列。

诗歌

代码变更如春风拂过,排序操作点缀其中 🐇✨
ChunkGraph更新焕新意,让代码更加清晰明了 🌟📦

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sorrycc sorrycc merged commit e7385a2 into master May 7, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/hash_consistent_ensure_order branch May 7, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]构建时会因为 dynamic import 的 ensure 顺序不同导致 hash 不稳定
2 participants