Hotfix: Tiptap media upload, prevent pasted HTML fragments #17518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
containing images, being uploaded to the server.
iOvergaard
approved these changes
Nov 12, 2024
iOvergaard
deleted the
v15/hotfix/tiptap-media-upload-prevent-paste-html
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17505.
When using the browser's "Copy image" feature, a HTML fragment is copied to the Clipboard, when pasting this into the Tiptap RTE, both the Image and Media Upload extensions were being triggered, showing duplicate images (one remote, one uploaded).
This fix prevents any image references that are pasted in from a HTML fragment to be uploaded to the server. The original (source) URL will be used for external image references.