Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: minor UI updates #17475

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Feature: minor UI updates #17475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96ede9a
use auto-heigth and auto-width
nielslyngsoe Nov 9, 2024
f232da7
adjust sidebar menu h3
nielslyngsoe Nov 9, 2024
df48c4a
Merge branch 'v15/dev' into v15/feature/minor-ui-updates
nielslyngsoe Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...ages/core/content-type/workspace/views/design/content-type-design-editor-group.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,8 @@ export class UmbContentTypeWorkspaceViewEditGroupElement extends UmbLitElement {
?disabled=${!this._hasOwnerContainer}
@blur=${this.#blurGroup}
@change=${this.#renameGroup}
${this._group!.name === '' ? umbFocus() : nothing}></uui-input>
${this._group!.name === '' ? umbFocus() : nothing}
auto-width></uui-input>
</div>
</div>
<div slot="header-actions">
Expand Down Expand Up @@ -208,10 +209,10 @@ export class UmbContentTypeWorkspaceViewEditGroupElement extends UmbLitElement {
<uui-input
type="number"
label=${this.localize.term('sort_sortOrder')}
.value=${this.group!.sortOrder ?? 0}
.value=${this.group!.sortOrder.toString()}
?disabled=${!this._hasOwnerContainer}
@change=${(e: UUIInputEvent) =>
this._singleValueUpdate('sortOrder', parseInt(e.target.value as string) || 0)}></uui-input>
this._singleValueUpdate('sortOrder', parseInt(e.target.value as string) ?? 0)}></uui-input>
`,
)}
</div>
Expand Down Expand Up @@ -245,7 +246,7 @@ export class UmbContentTypeWorkspaceViewEditGroupElement extends UmbLitElement {

#group-name {
--uui-input-border-color: transparent;
width: 100%;
min-width: 200px;
}

uui-input[type='number'] {
Expand Down
3 changes: 2 additions & 1 deletion ...s/core/content-type/workspace/views/design/content-type-design-editor-property.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,8 @@ export class UmbContentTypeDesignEditorPropertyElement extends UmbLitElement {
.value=${this.property.description}
@input=${(e: CustomEvent) => {
if (e.target) this.#singleValueUpdate('description', (e.target as HTMLInputElement).value);
}}></uui-textarea>
}}
auto-height></uui-textarea>
</p>
</div>
<uui-button
Expand Down
6 changes: 6 additions & 0 deletions ...Web.UI.Client/src/packages/core/menu/section-sidebar-menu/section-sidebar-menu.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ export class UmbSectionSidebarMenuElement<
manifest?: ManifestType;

renderHeader() {
/*
Notice we are not using the UUI-H3 here, we would need to wrap it into uui-text for this to take action,
but it does look odd so lets return to this later. I have made a few corrections especially for this component. [NL]
*/
return html`<h3>${this.localize.string(this.manifest?.meta?.label ?? '')}</h3>`;
}

Expand All @@ -44,7 +48,9 @@ export class UmbSectionSidebarMenuElement<
UmbTextStyles,
css`
h3 {
margin: var(--uui-size-5) 0;
padding: var(--uui-size-4) var(--uui-size-8);
font-size: 15px;
}
`,
];
Expand Down
3 changes: 2 additions & 1 deletion ...s/core/property-type/workspace/views/settings/property-workspace-view-settings.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,8 @@
@input=${this.#onDescriptionChange}
label=${this.localize.term('placeholders_enterDescription')}
placeholder=${this.localize.term('placeholders_enterDescription')}
.value=${this._data?.description}></uui-textarea>
.value=${this._data?.description}
auto-height></uui-textarea>

Check warning on line 251 in src/Umbraco.Web.UI.Client/src/packages/core/property-type/workspace/views/settings/property-workspace-view-settings.element.ts

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Large Method 

UmbPropertyTypeWorkspaceViewSettingsElement.render has 70 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
</div>
<umb-form-validation-message>
<umb-data-type-flow-input
Expand Down
Loading