Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: minor UI updates #17475

Merged
merged 3 commits into from
Nov 11, 2024

Merge branch 'v15/dev' into v15/feature/minor-ui-updates

df48c4a
Select commit
Loading
Failed to load commit list.
Merged

Feature: minor UI updates #17475

Merge branch 'v15/dev' into v15/feature/minor-ui-updates
df48c4a
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev) succeeded Nov 11, 2024 in 30s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.16 (10.00 -> 9.84)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method property-workspace-view-settings.element.ts: UmbPropertyTypeWorkspaceViewSettingsElement.render

Annotations

Check warning on line 251 in src/Umbraco.Web.UI.Client/src/packages/core/property-type/workspace/views/settings/property-workspace-view-settings.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Large Method 

UmbPropertyTypeWorkspaceViewSettingsElement.render has 70 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis