-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fluent API for adding webhook events and add document type events #15345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecific webhook events
1 task
ronaldbarendse
changed the title
Use fluent API for adding webhook events
Use fluent API for adding webhook events and add document type events
Dec 4, 2023
…ember group webhook events
ronaldbarendse
changed the base branch from
v13/feature/webhook-extensions
to
v13/dev
December 4, 2023 09:18
ronaldbarendse
commented
Dec 4, 2023
Zeegaan
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this approach, just needs proper documenting 🙈
I have a task this sprint for documenting, so noting this down 👍
…k events (instead of only template/partial view)
@Zeegaan @ronaldbarendse Ping me when this is merged and then I can fix up #15337 and merge it as well 👍 |
1 task
1 task
74 tasks
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Extending on PR #15344, this makes adding webhook events use a (nested) fluent API, so adding only content events can be done the following way:
Similarly, adding all events can be done using
builder.WebhookEvents().AddCms()
or just user login events usingAddCms(cmsBuilder => cmsBuilder.AddUser(userBuilder => userBuilder.AddLogin()))
.Other products and packages could use a similar structure, e.g.
AddForms()
,AddDeploy()
andAddCommerce()
... And if we add more events of a specific type, a nested fluent API can be easily created by adding a new overload that accepts theAction<FluentBuidlerTypeName>
.