-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V13: Webhook all the things #15161
V13: Webhook all the things #15161
Conversation
…uageWebHooks Will allow devs to easily pick and choose a category or related collection of WebHooks
Hey @warrenbuckley , I just wanted to make sure you were aware of this PR currently being worked on because I think it's touching/modifying the same parts as you: #15157 |
@mikecp OK gonna pause & catch up on that thread over there... |
Note: Renames the existing Save & Delete to be Saved and Deleted to be inline with rest of WebHooks
…ook-all-the-things # Conflicts: # src/Umbraco.Core/Constants-WebhookEvents.cs # src/Umbraco.Core/Webhooks/Events/Media/MediaDeletedWebhookEvent.cs # src/Umbraco.Core/Webhooks/Events/Media/MediaSavedWebhookEvent.cs # tests/Umbraco.Tests.Integration/Umbraco.Core/Services/WebhookServiceTests.cs
Just so I can move from main computer to laptop to carry on some hacking for now :)
…ook-all-the-things
Note the casing change
@Zeegaan before I wrap this up and do anymore, is it likely this PR will be accepted? |
Depends on how well you can argue your use case to @bergmania I think 🙈 |
@bergmania let me know what you think matey 😄 |
@warrenbuckley, I like the idea, just go for it 💪 🏃 |
@Zeegaan surely worth me doing a separate PR for that once this is merged |
…/webhook-all-the-things
…ook-all-the-things
…eir friendly name
…ook-all-the-things
UX improvementUpdated PR for the EventPicker Infinite Editor so that the events are ordered by the friendly Recording.2023-11-28.114918.mp4 |
Maybe we could just have a dropdown to filter the category, e.g. Content, Media, (Member), DataType, etc. which filter the event by name (or prefix) and IIRC a selection will filter other event types from the list anyway.
|
@bjarnef yes perhaps we could, but for now I followed another UX pattern that was already in the backoffice. |
…om/warrenbuckley/Umbraco-CMS into v13/feature/webhook-all-the-things
…my mind from before)
I've added a few commits for consistency but I think this is great for now! I'd love a hint from @ronaldbarendse on how to move to an extension method, but we have a bit of time before the next RC comes out (I've noted down to follow up on it). Other than that it all seems to work great and we're happy to have this ship in v13! 🎉 Thanks very much @warrenbuckley for all the work on this, really cool stuff! |
Prerequisites
If there's an existing issue for this PR then this fixes
Description
This adds in more WebHooks into the CMS as the are plenty of Notifications/Events raised by Umbraco that people may want to be notified by as a webhook posted externally to a third party system.
This PR adds in a lot of WebHook Event Types but they are not automatically added by default and would require you to update the Webhook Collection in a composer like so, where an implementor can pick and choose what collection of WebHooks they want to add.
Test Notes
Updated
Content
DataType
Dictionary
Domain
Language
Media
MediaType
Member
Member Type
Package
Public Access
Relation
Script
Stylesheet
Template
User