-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimeGate missing/broken #37
Comments
Looks like the timemaps are missing too (although they do appear in the headers of the TG response) https://www.webarchive.org.uk/wayback/archive/timemap/link/https://www.bl.uk |
Note that these links should behave as expected by the Memento standard, even in the absence of e.g. an |
I was looking at MemGator logs and see some success responses till October 30, but after that all responses are 404s. Does this align with the timeline of any changes made on the server? |
@ibnesayeed Yes, it does. Curiously, the service says the TimeMap is where I expect:
But when you go there it doesn't work...
|
- support memento timegate on top-frame (when no timestamp is provided) - treat top-frame no-timestamp url as canonical timegate - update tests
- support memento timegate on top-frame (when no timestamp is provided) - treat top-frame no-timestamp url as canonical timegate - tests: update tests, add memento redirect mode tests for timegate, timegate with accept-dt header
- support memento timegate on top-frame (when no timestamp is provided) - treat top-frame no-timestamp url as canonical timegate - tests: update tests, add memento redirect mode tests for timegate, timegate with accept-dt header
Hm, so the TimeGate seems to work now:
But the TimeMaps not so much?
|
- fix timemap in 'redirect-to-exact' mode, (ensure timegate redirect condition applies only to top-frame) - tests: add additional timemap tests, with and without exact redirect
@anjackson is this change deployed yet? |
@ibnesayeed Easy tiger! 🐅 😄 Just building the image at the moment. Will roll out to beta.webarchive.org.uk later on. |
Woo! Looks good!
Queries are still a little slow in some I'm going to tag a 1.0.6 release and roll it out. |
Oh it's much better in general! This might just be larger sites, e.g. https://www.webarchive.org.uk/wayback/archive/*/http://www.bbc.co.uk/ has quite a long pause while it assembles the data. |
TimeMaps are still not in good shape. Each memento entry returns URI-Rs, not URI-Ms. |
Hm, and 'misses' (should be 404s) throw errors... https://www.webarchive.org.uk/wayback/archive/http://www.no.domain/ NOTE TO SELF: Disable debug mode before rolling out next time! :-) |
Okay, I think we're good. Need to disable DEBUG mode, but functionality should be there. |
Looks much better. However, I am wondering if we should return a Also, it is taking somewhere between 10-20 seconds for
|
I'm not seeing that type of delay, no more than ~1 sec here
|
Now, I don't see it either. However, inclusion of |
- support memento timegate on top-frame (when no timestamp is provided) - treat top-frame no-timestamp url as canonical timegate - tests: update tests, add memento redirect mode tests for timegate, timegate with accept-dt header
- fix timemap in 'redirect-to-exact' mode, (ensure timegate redirect condition applies only to top-frame) - tests: add additional timemap tests, with and without exact redirect
As per this thread, we have a report that the Memento TimeGate is not where it is expected according to the documentation.
Specifically it seems the URI of the UKWA TimeGate has changed from:
to:
This seems likely to be a bug, probably introduced by our theming/overlaid changes. We should probably add an integration test to check the TG is there.
The text was updated successfully, but these errors were encountered: