Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Timemap 404 / Fuzzy Matching Limit Fixes #10

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Conversation

ikreymer
Copy link

@ikreymer ikreymer commented Feb 18, 2019

Description

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

…ess 200 response

fuzzy match limit: add 'fuzzy_search_limit' option to default_filters in rules.yaml
default fuzzy matching search limit to 100 results to avoid timeouts for large result sets that don't have any matches
Copy link

@anjackson anjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anjackson anjackson merged commit 384c4bc into master Feb 19, 2019
@anjackson anjackson deleted the memento-fuzzy-fix branch February 19, 2019 11:26
@anjackson
Copy link

Deployed on beta and looks good, so tagging as 1.0.9 and rolling to live.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants