-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace black and flake8 with ruff #3424
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3424 +/- ##
=======================================
Coverage 29.56% 29.56%
=======================================
Files 78 78
Lines 19131 19131
=======================================
Hits 5656 5656
Misses 13475 13475 ☔ View full report in Codecov by Sentry. |
Rules that are not going to be implemented but will be papercuts: |
875e617
to
de73c85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor spelling error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with doc changes
Update our codebase to use
ruff
as a formatter instead ofblack
, and useruff
as a linter instead offlake8
. The benefits of this change are:The downsides could be merge conflicts in the short term.