Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child states missing when lazy loading #46

Closed
1 of 3 tasks
christopherthielen opened this issue Mar 17, 2017 · 4 comments
Closed
1 of 3 tasks

child states missing when lazy loading #46

christopherthielen opened this issue Mar 17, 2017 · 4 comments
Labels
Milestone

Comments

@christopherthielen
Copy link
Member

From @Spyro92 on March 17, 2017 1:9

This is a:

  • Bug Report
  • Feature Request
  • General Query

My version of UI-Router is: 1.0.0-rc.1

Bug Report

Current Behavior:

When lazy loading states, any states registered in modules that are dependencies to the module being lazy loaded will not be registered.

in the example: lazy.foo is being registered, but not lazy.bar

it seems to be a timing issue, if you remove the dependency on lazy.bar from the module 'lazy' the state will be registered.

Expected Behavior:

lazy.bar and lazy.foo should be registered

Link to Plunker that reproduces the issue:

http://plnkr.co/edit/IfxBMmsZgKVAyxSZ7w0g?p=info

Copied from original issue: angular-ui/ui-router#3375

@christopherthielen
Copy link
Member Author

Thank you for the excellent bug report with plunker

@christopherthielen
Copy link
Member Author

This is the same bug as ui-router/angular#40 and needs to be fixed in ui-router/core

@nickeliah1
Copy link

Thanks for your quick work on this!
Will ui-router/core v5.0.0 be going live with angular-ui/ui-router 1.0.0-rc.2?

@christopherthielen
Copy link
Member Author

christopherthielen commented Mar 28, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants