Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child states missing when lazy loading #3375

Closed
1 of 3 tasks
nickeliah1 opened this issue Mar 17, 2017 · 4 comments
Closed
1 of 3 tasks

child states missing when lazy loading #3375

nickeliah1 opened this issue Mar 17, 2017 · 4 comments

Comments

@nickeliah1
Copy link

This is a:

  • Bug Report
  • Feature Request
  • General Query

My version of UI-Router is: 1.0.0-rc.1

Bug Report

Current Behavior:

When lazy loading states, any states registered in modules that are dependencies to the module being lazy loaded will not be registered.

in the example: lazy.foo is being registered, but not lazy.bar

it seems to be a timing issue, if you remove the dependency on lazy.bar from the module 'lazy' the state will be registered.

Expected Behavior:

lazy.bar and lazy.foo should be registered

Link to Plunker that reproduces the issue:

http://plnkr.co/edit/IfxBMmsZgKVAyxSZ7w0g?p=info
@christopherthielen
Copy link
Contributor

Thank you for the excellent bug report with plunker

@christopherthielen
Copy link
Contributor

This is the same bug as ui-router/angular#40 and needs to be fixed in ui-router/core

@christopherthielen
Copy link
Contributor

This issue was moved to ui-router/core#46

@christopherthielen christopherthielen mentioned this issue Mar 17, 2017
Closed
3 tasks
@christopherthielen
Copy link
Contributor

http://plnkr.co/edit/yyiZWGpnRvmsiZdhyceP?p=preview

Fix coming soon.

christopherthielen added a commit to ui-router/core that referenced this issue Mar 27, 2017
@christopherthielen
fix(lazyLoad): Wait for future state to be replaced before registerin…
4bdce47 
…g lazy children

Closes #46
Closes #40
Closes angular-ui/ui-router#3375
@lilstargazer lilstargazer mentioned this issue Mar 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christopherthielen @nickeliah1