Ng2LocationServices take account of APP_BASE_HREF. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,7 +11,8 @@ export class Ng2LocationServices extends BaseLocationServices { | |||
| } | |||
|
|
|||
| _get() { | |||
| return this._locationStrategy.path(true); | |||
| return this._locationStrategy.path(true) | |||
| .replace(this._locationStrategy.getBaseHref().replace(/\/$/, ''), ''); | |||
There was a problem hiding this comment.
it's unfortunate the location strategy class doesn't return the path without the base href.
It knows how to generate urls with the base href via prepareExternalUrl.
|
Looks good! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #32
Note: I'm not sure if this is the right solution ;)