Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta.4][Ng2LocationServices] take account of APP_BASE_HREF #32

Closed
aitboudad opened this issue Jan 23, 2017 · 4 comments · Fixed by #34
Closed

[beta.4][Ng2LocationServices] take account of APP_BASE_HREF #32

aitboudad opened this issue Jan 23, 2017 · 4 comments · Fixed by #34
Labels
bug
Milestone
1.0.0-beta.5

Comments

@aitboudad
Copy link
Contributor

Ng2LocationServices doesn't take account of APP_BASE_HREF which produce `Maximum call stack size exceeded exception

<base href="/app/">

selection_064
@christopherthielen christopherthielen added this to the 1.0.0-beta.5 milestone Jan 23, 2017
@christopherthielen
Copy link
Member

Thanks; I'll release a beta.5 ASAP.

Closed by #33

@aitboudad
Copy link
Contributor Author

@christopherthielen wait #33 doesn't solve this issue

aitboudad added a commit to aitboudad/ng2 that referenced this issue Jan 23, 2017
@aitboudad
[fixed ui-router#32] Ng2LocationServices take account of APP_BASE_HREF.
b858bd6
@aitboudad aitboudad mentioned this issue Jan 23, 2017
Merged
@aitboudad
Copy link
Contributor Author

@christopherthielen see #34

@christopherthielen
Copy link
Member

Oh, I see :) Thanks, I'll take a look at the new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0.0-beta.5
Development

Successfully merging a pull request may close this issue.

Ng2LocationServices take account of APP_BASE_HREF. aitboudad/ng2
2 participants
@aitboudad @christopherthielen