Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature reorg ozphys #1851

Merged
merged 42 commits into from
Nov 2, 2023
Merged

Conversation

dustinswales
Copy link
Collaborator

@dustinswales dustinswales commented Aug 2, 2023

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
    • LOG: /scratch1/BMC/gmtb/Dustin.Swales/UFS/ozone_phys/ufs-weather-model/tests/logs/RegressionTests_hera.log
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

This PR contains a reorganization of the NRL (2015) ozone physics parameterization.

Linked Issues and Pull Requests

None

Associated UFSWM Issue to close

None

Subcomponent Pull Requests

NOAA-EMC/f3atm/pull/662
ufs-community/ccpp-physics/662

Blocking Dependencies

None

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@dustinswales dustinswales marked this pull request as draft August 2, 2023 22:59
@dustinswales dustinswales marked this pull request as ready for review October 12, 2023 04:00
@DeniseWorthen
Copy link
Collaborator

Checking

/scratch1/NCEPDEV/stmp2/Jong.Kim/FV3_RT/rt_111654/compile_atm_dyn32_intel/build_fv3_atm_dyn32_intel/FV3/ccpp/ccpp_prebuild.err

INFO: Checking for existence of schemes in suites ...
CRITICAL: Scheme ozphys_2015 in suite FV3_GFS_v17_p8_ugwpv1 cannot be found
CRITICAL: Scheme phys_tend in suite FV3_GFS_v17_p8_ugwpv1 cannot be found
Traceback (most recent call last):

@dustinswales
Copy link
Collaborator Author

@jkbk2004 @DeniseWorthen
Sorry, I missed changes needed by two SDFs.
Should be working now.

@jkbk2004 jkbk2004 added No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ci Jenkins CI: ORT build/test on docker container labels Nov 1, 2023
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Nov 1, 2023

@BrianCurtis-NOAA FYI: issue was fixed and it runs ok.

@epic-cicd-jenkins
Copy link
Collaborator

Jenkins-ci ORTs passed

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Nov 2, 2023

We can start merging process.

@zach1221
Copy link
Collaborator

zach1221 commented Nov 2, 2023

@dustinswales fv3atm pr is merged. Please revert the .gitmodule url change, and update the submodule hash. Fv3atm hash: 29a9e833b9ee3ebb02523edc002aed47afe8e876

@zach1221 zach1221 merged commit 971cfc5 into ufs-community:develop Nov 2, 2023
@dustinswales dustinswales deleted the feature_reorg_ozphys branch January 6, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins-ci Jenkins CI: ORT build/test on docker container No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants