Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FV3 changes for refactored ozone physics scheme #661

Merged
merged 35 commits into from
Nov 2, 2023

Conversation

dustinswales
Copy link
Contributor

Description

This PR contains modifications to accommodate changes to the NRL ozone physics parameterization.

There are new interstitials variables for the data needed by the ozone scheme. The scheme data is ingested in GFS_typedefs:control_initialize() and provided to the scheme via interstitials, previously this data was stored on the HEAP within the scheme. Organizing the scheme this way removes the need for the scheme to access shared memory, making the scheme "stateless".

Issue(s) addressed

ccpp-physics #74

Testing

Coming soon...

@dustinswales dustinswales marked this pull request as ready for review August 2, 2023 17:42
@dustinswales dustinswales marked this pull request as draft August 2, 2023 22:59
@dustinswales
Copy link
Contributor Author

dustinswales commented Aug 2, 2023

@grantfirl I'm moving this PR, and the UWM PR, back to draft. It needs more input from othesr.

@dustinswales dustinswales marked this pull request as ready for review October 12, 2023 03:56
@grantfirl
Copy link
Collaborator

@dustinswales Can you pull in the latest ccpp-framework to this PR and update the description to say that we're doing this: NCAR/ccpp-framework@219f2e9 ? I've tested this commit of the ccpp-framework using UFS-RTs and everything was bit-for-bit, so this should not change any baselines.

@dustinswales
Copy link
Contributor Author

@DusanJovic-NOAA Ready to merge

@jkbk2004 jkbk2004 merged commit 29a9e83 into NOAA-EMC:develop Nov 2, 2023
@dustinswales dustinswales deleted the feature_reorg_ozphys branch January 6, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants