Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #191

Closed
wants to merge 10 commits into from
Closed

test #191

wants to merge 10 commits into from

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Dec 7, 2023

No description provided.

Signed-off-by: bitliu <[email protected]>
@Xunzhuo Xunzhuo requested a review from xudafeng as a code owner December 7, 2023 08:49
@uestcer uestcer deleted a comment from github-actions bot Dec 7, 2023
@uestcer uestcer deleted a comment from github-actions bot Dec 7, 2023
@uestcer uestcer deleted a comment from github-actions bot Dec 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

🚀 Thank you for contributing to the Envoy Gateway project! 🚀

Your PR has been successfully submitted, and we greatly appreciate your effort and contribution. Before merging, please ensure to follow the process below:

  1. Requesting Reviews:
  • cc @envoyproxy/gateway-reviewers team for an initial review.
  • After the initial review, reviewers should request the @envoyproxy/gateway-maintainers team for further review.
  1. Review Approval:
  • Your PR needs to receive at least two approvals.
  • At least one approval must come from a member of the gateway-maintainers team.

Our Build and Test Workflow will run a series of checks on your code to ensure it meets our quality standards and coding conventions. In the meantime, you can help expedite the processing of your PR by:

  • Ensuring you have self-reviewed your work according to the project's Contribution Guidelines.
  • If your PR addresses a specific issue, make sure to mention it in the PR description.
  • Respond promptly if there are any test failures or suggestions for improvements that we comment on.

Envoy Gateway team will review your PR as soon as possible. If all goes well, your code will soon be merged into the main branch. Should further modifications be required or if there are any questions, we will communicate with you in the PR comments.

Thank you once again for your contribution, we look forward to your excellent code bringing more possibilities to the Envoy Gateway!

Happy coding!

@uestcer uestcer deleted a comment from github-actions bot Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

🚀 Thank you for contributing to the Envoy Gateway project! 🚀

Before merging, please ensure to follow the process below:

  1. Requesting Reviews:
  • cc @envoyproxy/gateway-reviewers team for an initial review.
  • After the initial review, reviewers should request the @envoyproxy/gateway-maintainers team for further review.
  1. Review Approval:
  • Your PR needs to receive at least two approvals.
  • At least one approval must come from a member of the gateway-maintainers team.

NOTE: Once your PR is under review, please do not rebase and force push it. Otherwise, it will force your reviewers to review the PR from scratch rather than simply look at your latest changes.

What's more, you can help expedite the processing of your PR by
  • Ensuring you have self-reviewed your work according to the project's Contribution Guidelines.
  • If your PR addresses a specific issue, make sure to mention it in the PR description.
  • Respond promptly if there are any test failures or suggestions for improvements that we comment on.

@Xunzhuo Xunzhuo closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant