-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add PR comment and cc reviewers #2280
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2280 +/- ##
==========================================
- Coverage 64.38% 64.37% -0.02%
==========================================
Files 112 112
Lines 15874 15874
==========================================
- Hits 10221 10219 -2
- Misses 5004 5005 +1
- Partials 649 650 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: bitliu <[email protected]>
I have no objection to this, but not sure this's good to go, @envoyproxy/gateway-maintainers PTAL. |
i think the comment is quiet long, how about shrinking down to, for example, like: 🚀 Thank you for contributing to the Envoy Gateway project! 🚀 Before merging, please ensure to follow the process below:
What's more, you can help expedite the processing of your PR by
|
BTW, if you really want to add this, please mention that don't use force push like envoy does for better review. |
Signed-off-by: bitliu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: bitliu <[email protected]>
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
We tried a couple of ways to auto request reviews from @envoyproxy/gateway-reviewers, but it failed, and I tried it too today, failed again.
So current way is to add a welcome comment to cc @envoyproxy/gateway-maintainers and @envoyproxy/gateway-reviewers, they should get the ping too.