Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a script to run sensitivities #44

Merged
merged 7 commits into from
Sep 26, 2024
Merged

Adds a script to run sensitivities #44

merged 7 commits into from
Sep 26, 2024

Conversation

lshaver
Copy link
Contributor

@lshaver lshaver commented Sep 25, 2024

This PR adds a script which runs sensitivities on the model by changing the source year for fuel cost data, the load growth, and the initial demand (a proxy for whether Illinois is a net exporter of electricity).

To run the script, activate the environment and enter:
python sensitivity-script.py

The markdown file details what's being changed and why.

This also makes one small change to plot_results.py. The plot now shows only battery discharge, not the net of discharge and charge.

@lshaver lshaver requested a review from samgdotson September 25, 2024 19:25
@lshaver lshaver self-assigned this Sep 25, 2024
@pep8speaks
Copy link

pep8speaks commented Sep 25, 2024

Hello @lshaver! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-09-26 16:04:53 UTC

Copy link
Member

@samgdotson samgdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "changes" I'm requesting are just responses to some of my questions in the review. I think it looks pretty good and although it's not a perfect solution, if it works, I'm OK with it, for now.

In the future, there are ways to conduct sensitivity analyses directly with Snakemake. Here's one example. We should keep this in mind for future projects. Not necessarily for this one.

sensitivity-script.py Outdated Show resolved Hide resolved
sensitivity-script.py Outdated Show resolved Hide resolved
sensitivity.md Outdated Show resolved Hide resolved
sensitivity.md Outdated Show resolved Hide resolved
scripts/plot_results.py Show resolved Hide resolved
@samgdotson samgdotson added this to the Final model run milestone Sep 25, 2024
@lshaver lshaver requested a review from samgdotson September 26, 2024 17:09
Copy link
Member

@samgdotson samgdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, these changes look good to me! Though, I am writing for posterity that I think it would be better to use Snakemake directly.

@samgdotson samgdotson merged commit 5cc6305 into main Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants