-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a script to run sensitivities #44
Conversation
Generation plot formerly showed net (discharge less charge). Updated to just show discharge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "changes" I'm requesting are just responses to some of my questions in the review. I think it looks pretty good and although it's not a perfect solution, if it works, I'm OK with it, for now.
In the future, there are ways to conduct sensitivity analyses directly with Snakemake. Here's one example. We should keep this in mind for future projects. Not necessarily for this one.
Co-authored-by: Sam Dotson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, these changes look good to me! Though, I am writing for posterity that I think it would be better to use Snakemake directly.
This PR adds a script which runs sensitivities on the model by changing the source year for fuel cost data, the load growth, and the initial demand (a proxy for whether Illinois is a net exporter of electricity).
To run the script, activate the environment and enter:
python sensitivity-script.py
The markdown file details what's being changed and why.
This also makes one small change to
plot_results.py
. The plot now shows only battery discharge, not the net of discharge and charge.