Addresses overly optimistic wind capacity factor issue #36
Conversation
samgdotson
added
Type:Bug
|
Hello @samgdotson! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-09-03 14:34:03 UTC |
| @@ -1,13 +1,13 @@ | |||
| state_abbr: 'IL' | |||
| version: "5.0-test" | |||
| scenario: "no_growth_no_export" | |||
There was a problem hiding this comment.
Will you be doing a growth scenario in this analysis?
There was a problem hiding this comment.
Yes, as discussed. The config file represents the easily tunable parameters. In the technical appendix we can have a table describing the value of each (or a select set) parameter for a particular scenario.
| n.generators.carrier).sum().T | ||
|
|
||
| return p_by_carrier | ||
|
|
||
|
|
||
| def plot_dispatch(n, year=2025, month=7): |
There was a problem hiding this comment.
We'll talk about this on Thursday I'm sure, but as we are producing products for this analysis we may not want to show area plots - we might want to show bar charts or line charts instead (depending on the output). But we can go into more detail about that later.
|
|
||
| return fuel_costs | ||
|
|
||
|
|
||
| def load_existing_generators(): |
There was a problem hiding this comment.
I'm still a little confused on how you're dealing with "no exports" since the data that you have for existing generators included exports in that past year. Is this an issue?
There was a problem hiding this comment.
"Exports," here, just means that the total "demand" is equal to the total historical generation (since IL is an energy exporter). Removing "exports" means the total demand is equal to the historical retail sales within IL (about 2/3 of total generation).
|
@ssattler if you're satisfied with the changes in this pull request, would you mind hitting the big green "merge pull request" button? In general, it's best practice for somebody else (besides the person making the PR) to merge a pull request. For chronological reasons, this PR needs to be merged after #35. PRs are listed newest to oldest by default, so this one appears to be "first" on the list. Thanks! |
Important
This PR should be reviewed after #34 has been merged.
This PR closes #35 by adding a parameter to the
config.ymlfile calledcapacity_factor. Theadd_electricityrule modifies the wind availability time series by renormalizing to thecapacity_factorvalue.