Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time series fuel costs #34

Merged
12 commits merged into from
Sep 4, 2024
Merged

Time series fuel costs #34

12 commits merged into from
Sep 4, 2024

Conversation

samgdotson
Copy link
Member

@samgdotson samgdotson commented Aug 29, 2024

This PR adds a new rule to the workflow that accesses time series cost data from the PUDL project. Merging this PR closes #29 and closes #30.

Important

After the reviewer(s) have approved the PR, please update the "end date" under the "projects" tab on the right hand side. You may need to expand the view by clicking "+2 more".

How the data is processed

  1. The cost data are downloaded and come in $/MMBTU on a monthly basis.
  2. The data are multiplied by the appropriate heat rates to get fuel costs in $/MWh
  3. NaN values are removed by linear interpolation.
  4. The data are resampled to the appropriate hourly scale using a forward-fill strategy.
  5. Lastly, in the add_electricity rule, the VOM costs are added to each timestep.

@samgdotson samgdotson added Comp:Build This issue has to do with the build system of the code/doc (makefiles, cmake, install errors) Comp:Input This issue has to do with the input component of the code or document. (input parameters, prep) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:1-Critical This is the highest priority (i.e. it is blocking other work or facing a deadline). Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) Type:Feature New feature or feature request labels Aug 29, 2024
@samgdotson samgdotson added this to the 2nd Set of Model Runs milestone Aug 29, 2024
@samgdotson samgdotson requested review from lshaver and ssattler August 29, 2024 19:22
@samgdotson samgdotson self-assigned this Aug 29, 2024
@pep8speaks
Copy link

pep8speaks commented Aug 29, 2024

Hello @samgdotson! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 7:1: E402 module level import not at top of file

Comment last updated at 2024-09-03 14:10:30 UTC

@samgdotson
Copy link
Member Author

Hello @samgdotson! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 7:1: E402 module level import not at top of file

Comment last updated at 2024-09-03 14:10:30 UTC

I'm ignoring this PEP8 issue because the preceding line sys.path.append("functions") is necessary to import the module in question. Perfect adherence to the style guide, here, would break functionality.

Copy link
Contributor

@ssattler ssattler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine - I had my comments in the earlier pull request,
-Sandra

@samgdotson
Copy link
Member Author

Thanks @ssattler! If you're satisfied with these changes, would you mind clicking the big green "Merge pull request button?"

This PR needs to be merged before #36.

@ssattler ssattler closed this pull request by merging all changes into main in c3b2424 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp:Build This issue has to do with the build system of the code/doc (makefiles, cmake, install errors) Comp:Input This issue has to do with the input component of the code or document. (input parameters, prep) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:1-Critical This is the highest priority (i.e. it is blocking other work or facing a deadline). Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) Type:Feature New feature or feature request
Projects
None yet
3 participants