Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds solar and wind generators to the model #12

Merged
merged 5 commits into from
May 28, 2024
Merged

Adds solar and wind generators to the model #12

merged 5 commits into from
May 28, 2024

Conversation

samgdotson
Copy link
Member

@samgdotson samgdotson commented May 24, 2024

This pull request closes #5 by adding solar and wind generators to the illinois model notebook. Included are the following

  • A notebook that extracts data from NREL for solar and wind resources
  • A section in the illinois_model.ipynb notebook that explains the data manipulations (specifically, we just want the shape of the generation so it can be scaled by the optimal capacity, later).
  • The wind and solar generators are added to the model.
  • The model runs successfully.

Currently, the solar and wind resources are only considered at a single point in each modeled region (the centroid). In the future, we may consider expanding the distribution of these resources by increasing the number of buses, for example (each bus does not have to have a load).

Edit:
This PR also directly adds the relevant datasets.

@samgdotson samgdotson added Comp:Input This issue has to do with the input component of the code or document. (input parameters, prep) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) labels May 24, 2024
@samgdotson samgdotson requested a review from lshaver May 24, 2024 18:12
@samgdotson samgdotson self-assigned this May 24, 2024
Copy link
Contributor

@lshaver lshaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor typos/errors that need to be corrected in future pull requests but otherwise everything seems to be working well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data readme says that transmission data should be in "transmission-lines", while the notebook is actually expecting "transmission_lines". The readme also says it is expecting service territory data in "service-territories" but is actually expecting it in "spatial-data". There's a typo on the line to read this file, with the path starting "../../" where it should instead start "../data/".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same typo: "../../" for "../data/"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instructions for adding the NREL api key to the conda environment would be helpful, including a way to change the personal data dictionary as needed in the nrel_data_api.py function.

@lshaver lshaver merged commit 3852140 into main May 28, 2024
@lshaver
Copy link
Contributor

lshaver commented May 30, 2024

In reviewing the code again I see this assumption which I'm a bit concerned about: "However, if we assume that temperature has no effect on panel performance, then the output power and incident power are linearly related." With rising temperatures and more solar on the grid, ignoring the reduction in solar output on hot summer days will distort the model. Should we address this?

@samgdotson
Copy link
Member Author

Average temperatures are rising, but for a first order model (which is what we're trying to achieve right now), it doesn't make sense to incorporate. Even if we did, the effect would be quite small. We can circle back on this in the future though, if you think it's important.

@lshaver
Copy link
Contributor

lshaver commented Jun 3, 2024

Looks like there's about a 5% loss in performance going from panel rating temperature to 35 degC, the average high in Chicago (in July). During peak hours this could be significant, but I agree it's probably not worth including in the model at this point. It could be an interesting sensitivity to do later, possibly even incorporating future and extreme weather data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp:Input This issue has to do with the input component of the code or document. (input parameters, prep) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add renewable resources to the model
2 participants