Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows nav:goto to ignore navigation locks by default, adds a new setting to enforce navigation lock per action. #1952

Conversation

FrenjaminBanklin
Copy link
Contributor

Closes #1948

Adds an 'ignore lock' toggle to nav:goto actions which defaults to true, allowing all existing button-based navigation to continue working while also allowing authors to respect navlocks, or at least inform them when they do not.

…efaults to true, allowing all existing button-based navigation to continue working while also allowing authors to respect navlocks, or at least inform them when they do not.
Copy link
Member

@deundrewilliams deundrewilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ignore navigation toggle works, allowing navigation when it's switched on, but it only works with 'Go to' and not 'Go to previous page' or 'Go to next page'. Should the toggle be added to these options, or is it fine to not have it since the user can just enter the ID of the next/prev page in the field?

@FrenjaminBanklin
Copy link
Contributor Author

@jpeterson976 worked on this more recently so he may remember if the 'Next Page' and 'Previous Page' buttons still worked regardless of the navigation being locked, but I don't think they did. If not, it would be inconsistent to allow a triggered nav:prev or nav:next action to optionally ignore the navigation lock.

It wouldn't be hard to enable the new optional behavior for nav:prev and nav:next, and I thought about doing so, but I think it makes sense for those two to respect navigation locks at all times based on the above assumption. With nav:goto I can think of situations where authors want the nav to stay locked but for specific situations to still move students around in the content.

Copy link
Contributor

@jpeterson976 jpeterson976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked my old PR, nav:prev and nav:next did not previously work when navigation was locked, so Brandon's assumption was correct.

The new toggle switch also works as advertised, so this gets my approval.

@FrenjaminBanklin FrenjaminBanklin merged commit 8c6d8b3 into ucfopen:dev/27-pyrite Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants