Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the ability for button-based navigation to ignore navigation locks. #1948

Closed
FrenjaminBanklin opened this issue Jan 20, 2022 · 0 comments
Assignees

Comments

@FrenjaminBanklin
Copy link
Contributor

FrenjaminBanklin commented Jan 20, 2022

Reverses/amends the solution for #775.

It's easy for content authors to create situations in which end users can become stuck in a certain page due to navigation being locked. Previously, nav:goto triggers were able to bypass navigation locks which, in some cases, would cause problems and, in other cases, solve problems.

In practice, that behavior ended up becoming load-bearing. Existing content can now be assumed to have the expectation that buttons using the nav:goto trigger will assume that navigation will still work regardless of being locked.

Either rewind the fix and allow nav:goto triggers to ignore navigation locks again, or embellish such events with an extra configurable property which makes it explicit that the buttons will respect any locks on the navigation.

See https://github.com/ucfopen/Obojobo/pull/1911/files as a reference for what changed to disable the previous behavior.

@FrenjaminBanklin FrenjaminBanklin self-assigned this Jan 20, 2022
FrenjaminBanklin added a commit to FrenjaminBanklin/Obojobo that referenced this issue Jan 21, 2022
…efaults to true, allowing all existing button-based navigation to continue working while also allowing authors to respect navlocks, or at least inform them when they do not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant