Move to SQLAlchemy 2 #187
Move to SQLAlchemy 2 #187
Conversation
This reverts commit fb5d508.
|
Depends on RudolfCardinal/pythonlib#23, and (for proper installation/distribution), on pushing cardinal_pythonlib==2.0.0 to PyPI. |
Until then you could pin cardinal_pythonlib to a git branch in
I have not tested this! |
|
boo, "Dependency is not satisfiable: libssl1.1" |
There was a problem hiding this comment.
Looks good to me. I've pushed a few more changes including a test fix and a pre-commit hook to check for blanket noqas.
Before merging, there's the zero length upsert_test_1.sql, which I think must have been checked in accidentally. It would be good also to test the changes from #180 on the CPFT server.
We'll also need to release the new cardinal_pythonlib and update setup.py
There was a problem hiding this comment.
Accidentally checked in?
There was a problem hiding this comment.
Yes! Sorry. Removed.
| configtext = self._mk_nlp_config() | ||
| log.debug(configtext) | ||
| f.write(configtext) | ||
| # import pdb; pdb.set_trace() |
There was a problem hiding this comment.
| # import pdb; pdb.set_trace() |
|
Thanks - checks in progress but have incorporated suggestions above. But will wait as you suggest until CPFT tests complete; just say when (or feel free). |
No description provided.