-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQLAlchemy 2 update, and bump to 2.0.0 #23
Conversation
Also adding some support for Databricks. There is no generic way to convert SQL textual column types to dialect-specific SQLAlchemy column types (sqlalchemy/sqlalchemy#12230). This relates to |
Stop blanket #noqas and remove unnecessary ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I've added some pre-commit hooks for blanket and unnecessary #noqas.
There's a pattern we use in the CamCOPS and CRATE tests for database level testing with engines, sessions etc created in conftest.py
and injected into a common database test class. We might want to adopt this if these tests start getting slow.
Would it be worth asking the Databricks people about dialect.ischema_names
?
Have asked at databricks/databricks-sqlalchemy#11 |
No description provided.