fix: high contrast themes: ListTile selected state is not distinguishable from non-selected state

example/lib/pages/theme_page/src/containers/containers_view.dart

@@ -3,6 +3,13 @@ import 'package:yaru/yaru.dart';
 
 import '../constants.dart';
 
+const _icons = [
+  YaruIcons.address_book,
+  YaruIcons.application_bag,
+  YaruIcons.beaker,
+  YaruIcons.calendar_important,
+];
+
 class ContainersView extends StatefulWidget {
   const ContainersView({super.key});
 
@@ -13,12 +20,8 @@ class ContainersView extends StatefulWidget {
 class _ContainersViewState extends State<ContainersView> {
   var _elevation = 2.0;
   var _inDialog = true;
-  final _icons = [
-    YaruIcons.address_book,
-    YaruIcons.application_bag,
-    YaruIcons.beaker,
-    YaruIcons.calendar_important,
-  ];
+
+  final _selected = List.generate(_icons.length, (index) => false);
 
   @override
   Widget build(BuildContext context) {
@@ -69,6 +72,8 @@ class _ContainersViewState extends State<ContainersView> {
       containerWithBorder,
       for (var i = 0; i < _icons.length; i++)
         ListTile(
+          selected: _selected[i],
+          onTap: () => setState(() => _selected[i] = !_selected[i]),
           leading: Icon(_icons[i]),
           title: Text('ListTile title $i'),
           subtitle: i.isEven ? null : const Text('Subtitle'),

lib/src/icons/icons_widgets/yaru_animated_icons.dart

@@ -1,6 +1,4 @@
-import 'package:animated_vector/animated_vector.dart';
 import 'package:animated_vector_annotations/animated_vector_annotations.dart';
-import 'package:flutter/widgets.dart';
 
 part 'yaru_animated_icons.g.dart';
 

lib/src/themes/common_themes.dart

@@ -3,6 +3,7 @@ import 'dart:io';
 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
+import 'package:yaru/constants.dart';
 import 'package:yaru/theme.dart';
 
 import 'constants.dart';
@@ -779,9 +780,7 @@ ThemeData createYaruTheme({
     splashFactory: NoSplash.splashFactory,
     sliderTheme: _createSliderTheme(colorScheme),
     drawerTheme: _createDrawerTheme(colorScheme),
-    listTileTheme: ListTileThemeData(
-      iconColor: colorScheme.onSurface.withOpacity(0.8),
-    ),
+    listTileTheme: _createListTileTheme(colorScheme),
     snackBarTheme: _createSnackBarTheme(colorScheme),
     chipTheme: _createChipTheme(
       selectedColor: elevatedButtonColor ?? colorScheme.primary,
@@ -790,6 +789,24 @@ ThemeData createYaruTheme({
   );
 }
 
+ListTileThemeData _createListTileTheme(ColorScheme colorScheme) {
+  final isHighContrast = colorScheme.isHighContrast;
+  return ListTileThemeData(
+    selectedColor:
+        isHighContrast ? colorScheme.onInverseSurface : colorScheme.onSurface,
+    iconColor: colorScheme.onSurface.withOpacity(0.8),
+    selectedTileColor: isHighContrast
+        ? colorScheme.inverseSurface
+        : colorScheme.onSurface.withOpacity(0.08),
+    minVerticalPadding: 6,
+    visualDensity: const VisualDensity(horizontal: -4, vertical: -4),
+    shape: const RoundedRectangleBorder(
+      borderRadius: BorderRadius.all(Radius.circular(kYaruButtonRadius)),
+      side: BorderSide.none,
+    ),
+  );
+}
+
 CardTheme _createCardTheme(ColorScheme colorScheme) {
   return CardTheme(
     color: _cardColor(colorScheme),

lib/src/widgets/master_detail/yaru_master_tile.dart

@@ -1,6 +1,5 @@
 import 'package:flutter/material.dart';
 import 'package:yaru/constants.dart';
-import 'package:yaru/theme.dart';
 
 const double _kScrollbarThickness = 8.0;
 const double _kScrollbarMargin = 2.0;
@@ -59,20 +58,6 @@ class YaruMasterTile extends StatelessWidget {
               isSelected ? theme.colorScheme.onSurface.withOpacity(0.07) : null,
         ),
         child: ListTile(
-          selectedColor: theme.colorScheme.onSurface,
-          iconColor: theme.colorScheme.onSurface.withOpacity(0.8),
-          minVerticalPadding: 6,
-          visualDensity: const VisualDensity(horizontal: -4, vertical: -4),
-          shape: RoundedRectangleBorder(
-            borderRadius:
-                const BorderRadius.all(Radius.circular(kYaruButtonRadius)),
-            side: theme.colorScheme.isHighContrast && isSelected
-                ? BorderSide(
-                    color: theme.colorScheme.outlineVariant,
-                    strokeAlign: BorderSide.strokeAlignOutside,
-                  )
-                : BorderSide.none,
-          ),
           leading: leading,
           title: _titleStyle(context, title),
           subtitle: _subTitleStyle(context, subtitle),

pubspec.yaml

@@ -9,8 +9,8 @@ environment:
   flutter: ">=3.24.3"
 
 dependencies:
-  animated_vector: ^0.2.0
-  animated_vector_annotations: ^0.2.0
+  animated_vector: ^0.2.2
+  animated_vector_annotations: ^0.2.2
   assorted_layout_widgets: ^9.0.2
   collection: ^1.17.0
   dbus: ^0.7.10