fix: high contrast themes: ListTile selected state is not distinguishable from non-selected state

[Feichtmeier]

now the improved high contrast list tiles:

Fixes #939

Bonus:

Fixes #940

[Feichtmeier]

okay it works, but we have a new analyzer problem

@HrX03 @Jupi007

   info • The import of 'package:animated_vector/animated_vector.dart' is unnecessary because all of the used elements are also provided by the import of 'package:animated_vector_annotations/animated_vector_annotations.dart' • lib/src/icons/icons_widgets/yaru_animated_icons.dart:1:8 • unnecessary_import
   info • The import of 'package:flutter/widgets.dart' is unnecessary because all of the used elements are also provided by the import of 'package:animated_vector_annotations/animated_vector_annotations.dart' • lib/src/icons/icons_widgets/yaru_animated_icons.dart:3:8 • unnecessary_import

when I remove it yaru_animated_icons.dart is missing the import O.o
whats happening?

[HrX03]

okay it works, but we have a new analyzer problem

@HrX03 @Jupi007

   info • The import of 'package:animated_vector/animated_vector.dart' is unnecessary because all of the used elements are also provided by the import of 'package:animated_vector_annotations/animated_vector_annotations.dart' • lib/src/icons/icons_widgets/yaru_animated_icons.dart:1:8 • unnecessary_import
   info • The import of 'package:flutter/widgets.dart' is unnecessary because all of the used elements are also provided by the import of 'package:animated_vector_annotations/animated_vector_annotations.dart' • lib/src/icons/icons_widgets/yaru_animated_icons.dart:3:8 • unnecessary_import

when I remove it yaru_animated_icons.dart is missing the import O.o
whats happening?

I moved all of the required imports for generated files into the animated_vector_annotations file, I think the yaru lib will need to update to not include other stuff inside those files

[Jupi007]

Weird, I can't reproduce the analyzing error locally using your branch 🤔
Okay, I reproduced it

[Jupi007]

Yeah, it looks like you just need to drop animated_vector.dart and widgets.dart:

- import 'package:animated_vector/animated_vector.dart';
import 'package:animated_vector_annotations/animated_vector_annotations.dart';
- import 'package:flutter/widgets.dart';

[Feichtmeier]

Yeah, it looks like you just need to drop animated_vector.dart and widgets.dart:

- import 'package:animated_vector/animated_vector.dart';
import 'package:animated_vector_annotations/animated_vector_annotations.dart';
- import 'package:flutter/widgets.dart';

no I dont think this works : D

now I got 777 x Undefined class 'AnimatedVectorData'.
Try changing the name to the name of an existing class, or creating a class with the name 'AnimatedVectorData'.

[HrX03]

Yeah, it looks like you just need to drop animated_vector.dart and widgets.dart:

- import 'package:animated_vector/animated_vector.dart';
import 'package:animated_vector_annotations/animated_vector_annotations.dart';
- import 'package:flutter/widgets.dart';

no I dont think this works : D

now I got 777 x Undefined class 'AnimatedVectorData'.
Try changing the name to the name of an existing class, or creating a class with the name 'AnimatedVectorData'.

I have just checked and the member is exported from the file, did you update every animated_vector dep and ran pub get/upgrade? Also try restarting the analyzer, I'm sure the member is exported

[Feichtmeier]

Yeah, it looks like you just need to drop animated_vector.dart and widgets.dart:

- import 'package:animated_vector/animated_vector.dart';
import 'package:animated_vector_annotations/animated_vector_annotations.dart';
- import 'package:flutter/widgets.dart';

no I dont think this works : D
now I got 777 x Undefined class 'AnimatedVectorData'.
Try changing the name to the name of an existing class, or creating a class with the name 'AnimatedVectorData'.

I have just checked and the member is exported from the file, did you update every animated_vector dep and ran pub get/upgrade? Also try restarting the analyzer, I'm sure the member is exported

jeeez, sorry.

[Jupi007]

LGTM 👍

[Feichtmeier]

the goldens test passes locally, we need the nightly for this I think so this can be ignored