Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort out file guards in promise-android-tools #1575

Closed
DaBisounours opened this issue Nov 24, 2020 · 1 comment
Closed

Sort out file guards in promise-android-tools #1575

DaBisounours opened this issue Nov 24, 2020 · 1 comment
Assignees
@NeoTheThird
Labels
bug a bug in the software itself

Comments

@DaBisounours
Copy link

UBports Installer 0.7.4-beta (exe)
Environment: Microsoft Windows 10 Pro 10.0.18363 win32 10.0.18363 x64 18363 0.0 NodeJS v12.16.3
Device: bacon
Target OS: Ubuntu Touch
Settings: undefined
OPEN-CUTS run: https://ubports.open-cuts.org/run/5fbcd5a49702a600079de17c
Log: N/A

I'm guessing it comes from my user name "Evan Graïne" which happen to contain a whitespace and a french character.
The error:
Error: fastboot:flash: Error: Flashing failed: {"error":{"code":1},"stderr":"fastboot: error: cannot load 'Gra�ne\AppData\Roaming\ubports\bacon\firmware\boot-bacon.img': No such file or directory"}
The path should be C\Users\Evan Graïne\AppData\....
@NeoTheThird NeoTheThird changed the title Failed Install on OnePlus One from windows (with a peculiar user name) Sort out file guards in promise-android-tools Nov 30, 2020
@NeoTheThird NeoTheThird added the bug a bug in the software itself label Nov 30, 2020
@NeoTheThird
Copy link
Member

A related issue:

command: exec: {"cmd":["fastboot","boot","\"/home/geminis65/snap/ubports-installer/320/.cache/ubports/hammerhead/firmware/recovery-hammerhead.img\""],"error":{"message":"Command failed: fastboot boot \"/home/geminis65/snap/ubports-installer/320/.cache/ubports/hammerhead/firmware/recovery-hammerhead.img\"\nfastboot: error: cannot load '\"/home/geminis65/snap/ubports-installer/320/.cache/ubports/hammerhead/firmware/recovery-hammerhead.img\"': No such file or directory","code":1},"stderr":"fastboot: error: cannot load '\"/home/geminis65/snap/ubports-installer/320/.cache/ubports/hammerhead/firmware/recovery-hammerhead.img\"': No such file or directory"}

The quoted fileguards do not seem to work properly with the new promise-android-tools any more. Maybe we should move to backslashes instead.

@NeoTheThird NeoTheThird mentioned this issue Nov 30, 2020
Closed
@NeoTheThird NeoTheThird self-assigned this Dec 1, 2020
NeoTheThird added a commit to ubports/promise-android-tools that referenced this issue Dec 1, 2020
@NeoTheThird
Do not spawn a shell to avoid having to deal with fileguards, see ubp…
90cfd28 
…orts/ubports-installer#1575
@NeoTheThird NeoTheThird mentioned this issue Dec 1, 2020
Merged
NeoTheThird added a commit to ubports/promise-android-tools that referenced this issue Dec 3, 2020
@NeoTheThird
Handle more errors (#54)
b171069 
* Make sure not to access non-existent properties on push progress as seen in ubports/ubports-installer#1580

* Handle locked error on set_active, ubports/ubports-installer#1556

* Bump version

* only generate coverage on linux

* Do not spawn a shell to avoid having to deal with fileguards, see ubports/ubports-installer#1575

* Increase timeout on platform test

* work around shebang

* Catch lock error on vollaphone

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NeoTheThird NeoTheThird

Labels
bug a bug in the software itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DaBisounours @NeoTheThird