Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build-dx): Clean up pretty name in OS release info #2090

Merged
merged 3 commits into from
Jan 1, 2025
Merged

chore(build-dx): Clean up pretty name in OS release info #2090

merged 3 commits into from
Jan 1, 2025

Conversation

EyeCantCU
Copy link
Member

@EyeCantCU EyeCantCU commented Jan 1, 2025 •
edited
Loading

Remove -dx from the pretty name in OS release info to consolidate brew stats given it is a mode and not a variant

@EyeCantCU
chore(build-dx): Clean up pretty name in OS release info
091e0f2 
It could just be me, but Bluefin DX looks better aesthetically than Bluefin-dx
@EyeCantCU EyeCantCU requested a review from castrojo as a code owner January 1, 2025 02:40
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dx Developer Experience Image specific labels Jan 1, 2025
castrojo
castrojo requested changes Jan 1, 2025
View reviewed changes
Copy link
Member

@castrojo castrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this so our brew stats get consolidated? -dx shouldn't be a sku it's more of a mode.

build_files/shared/build-dx.sh Outdated Show resolved Hide resolved
@castrojo castrojo enabled auto-merge January 1, 2025 02:58
castrojo
castrojo previously approved these changes Jan 1, 2025
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 1, 2025
@castrojo castrojo added this pull request to the merge queue Jan 1, 2025
Merged via the queue into main with commit 46d0db8 Jan 1, 2025
30 checks passed
@castrojo castrojo deleted the cleanup-pretty-name branch January 1, 2025 04:28
@ledif ledif mentioned this pull request Jan 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castrojo castrojo castrojo approved these changes

Assignees
No one assigned
Labels
dx Developer Experience Image specific lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EyeCantCU @castrojo