chore(build-dx): consolidate os-release names #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
RealVishy
approved these changes
Jan 3, 2025
NiHaiden
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two separate but related changes:
Use same
PRETTY_NAMEfor Aurora and Aurora-dxMostly pulling from Bluefin's recent change ublue-os/bluefin#2090 to make it so both
AuroraandAurora-dxcount as a single entry in Homebrew's stats.This should bump Aurora up a few spots on https://formulae.brew.sh/analytics/os-version/30d.
Change name in KDE's Info Center
The
kcm-about-distrorcfile controls what is displayed in KDE's Info Center app. I noticed that Aurora's Info Center is using theVariantfield in a way that is both redundant (i.e., it is just theNamefield repeated) and different from how other KDE-based projects use that field, including Bazzite.Current
Proposed
I feel that having the
Variantfield be empty for the Aurora image and "Developer Experience" for the Aurora-dx image is more in line with the spirit of the field. I am attaching examples from other distros to provide a feel for how others do it.Other Distros