feat: fix auth double render

[zugdev]

Resolves #161

const gitHubUser: null | GitHubUser = await getGitHubUser();
  if (gitHubUser) {
    await trackReferralCode();
    await displayGitHubUserInformation(gitHubUser);
  }

  const accessToken = getGitHubAccessToken();
  if (!accessToken) {
    renderGitHubLoginButton();
  }

The problem with this code order is that getGitHubAccessToken() is the function that checks and clears expired tokens. Therefore GitHub user info is shown, and only afterwards we check if expired and show login button. To reproduce the error you can simply change accessToken to null:

 const accessToken = null;

Though I'd like to simplify auth sometime it's quicker to just switch the order back into correct place. I think we should increase our token expiry date though, 60 mins seems very short.

Here is the reproduced bug with a null accessToken:

currentCode.mp4

To QA this solution one can comment the following lines

//  if (accessToken) {
//    return accessToken;
//  }

in getGitHubAccessToken():

work.ubq.fi/src/home/getters/get-github-access-token.ts

Lines 29 to 47 in bd41261

	export async function getGitHubAccessToken(): Promise<string | null> {
	// better to use official function, looking up localstorage has flaws
	const oauthToken = await checkSupabaseSession();
	const expiresAt = oauthToken?.expires_at;
	if (expiresAt) {
	if (expiresAt < Date.now() / 1000) {
	localStorage.removeItem(`sb-${SUPABASE_STORAGE_KEY}-auth-token`);
	return null;
	}
	}
	const accessToken = oauthToken?.provider_token;
	if (accessToken) {
	return accessToken;
	}
	return null;
	}

and run with a clean cache. Whenever you login, GitHub info will never be shown.

[ubiquity-os-deployer]

a4986f2

56c94b0

b5a84f7

[0x4007]

There was some reason I changed the order I forgot the bug. I suppose you don't recall either.

Wasn't it throwing the error in the modal due to this?

[0x4007]

Also let's change the token expiry time to max

[zugdev]

Wasn't it throwing the error in the modal due to this?

No that was service worker related.