Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not display user info if access token is expired #161

Closed
zugdev opened this issue Nov 7, 2024 · 2 comments · Fixed by #162
Closed

do not display user info if access token is expired #161

zugdev opened this issue Nov 7, 2024 · 2 comments · Fixed by #162

Comments

@zugdev
Copy link
Contributor

zugdev commented Nov 7, 2024

Currently in authentication, we have two different conditions to show user GitHub info and the login button.

const gitHubUser: null | GitHubUser = await getGitHubUser();
if (gitHubUser) {
await trackReferralCode();
await displayGitHubUserInformation(gitHubUser);
}
const accessToken = await getGitHubAccessToken();
if (!accessToken) {
renderGitHubLoginButton();
}
}

This leads to a scenario where both can be shown at the same time or none is shown:

image

Copy link
Contributor

ubiquity-os bot commented Nov 8, 2024

Deadline Fri, Nov 8, 2:29 AM UTC
Beneficiary 0xbB689fDAbBfc0ae9102863E011D3f897b079c80F

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link
Contributor

ubiquity-os bot commented Nov 10, 2024

 [ 29.34 UUSD ] 

@zugdev
Contributions Overview
ViewContributionCountReward
IssueTask16
IssueSpecification123.34
ReviewComment10
Conversation Incentives
CommentFormattingRelevanceReward
Currently in authentication, we have two different conditions to…
7.78
content:
  content:
    p:
      score: 0
      elementCount: 4
    img:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 50
  wordValue: 0.1
  result: 2.78
123.34
Resolves #161 ```const gitHubUser: null | GitHub…
0
content:
  content:
    p:
      score: 0
      elementCount: 9
  result: 0
regex:
  wordCount: 147
  wordValue: 0
  result: 0
0.90

 [ 0.555 UUSD ] 

@0x4007
Contributions Overview
ViewContributionCountReward
ReviewComment10.555
Conversation Incentives
CommentFormattingRelevanceReward
There was some reason I changed the order I forgot the bug. I su…
1.85
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 31
  wordValue: 0.1
  result: 1.85
0.30.555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants