Swifty APIs #176
Merged
Swifty APIs #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobz
suggested changes
Sep 7, 2017
| @@ -107,6 +107,7 @@ import MapKit | |||
|
|
|||
| } | |||
|
|
|||
| // TODO: fix | |||
| @@ -96,6 +96,7 @@ import UIKit | |||
|
|
|||
| /** | |||
| * Object representing an access scope to the Uber API | |||
| * TODO: investigate why this is here | |||
There was a problem hiding this comment.
Let's not commit TODOs. Link an issue if there's followup work to do.
| @@ -87,48 +84,98 @@ import WebKit | |||
| */ | |||
| @objc(UBSDKConfiguration) open class Configuration : NSObject { | |||
| // MARK : Variables | |||
| open static var shared: Configuration = Configuration() | |||
There was a problem hiding this comment.
Doesn't this put us back in the Singleton situation? Is this a stopgap, or what's intention here?
There was a problem hiding this comment.
As discussed in person, this leaves us in the singleton situation but opens the possibility to injecting Configuration() objects into the RidesClient in the future to support multiple profiles.
bobz
approved these changes
Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update public APIs to adhere to the Swift API Design Guidelines.
Most of the changes in this PR are minor, and are related to renaming APIs, and renaming the consumer of the API in the tests.
The primary structural change in this PR is to change the
Configurationfrom a static object to a singleton, which will allow us in the future to improve testability and pave the way for multiple Uber Clients, if necessary for the end developer.