Swifty APIs (#176)

* Convert OAuth to Swifty API * Translated more Swift 3 APIs * Update tests for new SDK API * Remove TODO comment
uber · Sep 13, 2017 · ffddf05 · ffddf05
1 parent 5b1d143
commit ffddf05
Show file tree

Hide file tree

Showing 56 changed files with 674 additions and 893 deletions.
diff --git a/source/TestAppShim/Info.plist b/source/TestAppShim/Info.plist
@@ -33,6 +33,10 @@
 		<string>UIInterfaceOrientationPortrait</string>
 		<string>UIInterfaceOrientationLandscapeLeft</string>
 		<string>UIInterfaceOrientationLandscapeRight</string>
-	</array>
+    </array>
+    <key>UberClientID</key>
+    <string>UberTestClientID</string>
+    <key>UberDisplayName</key>
+    <string>UberTestDisplayName</string>
 </dict>
 </plist>
diff --git a/source/UberRides/AppStoreDeeplink.swift b/source/UberRides/AppStoreDeeplink.swift
@@ -39,9 +39,9 @@ import Foundation
         let domain = "m.uber.com"
         let path = "/sign-up"
 
-        let clientIDQueryItem = URLQueryItem(name: "client_id", value: Configuration.getClientID())
+        let clientIDQueryItem = URLQueryItem(name: "client_id", value: Configuration.shared.clientID)
 
-        let userAgent = userAgent ?? "rides-ios-v\(Configuration.sdkVersion)"
+        let userAgent = userAgent ?? "rides-ios-v\(Configuration.shared.sdkVersion)"
 
         let userAgentQueryItem = URLQueryItem(name: "user-agent", value: userAgent)
 

diff --git a/source/UberRides/BaseDeeplink.swift b/source/UberRides/BaseDeeplink.swift
@@ -74,8 +74,8 @@ import Foundation
      - parameter completion: The completion block to execute once the deeplink has
      executed. Passes in True if the url was successfully opened, false otherwise.
      */
-    @objc open func execute(_ completion: ((NSError?) -> ())? = nil) {
-        
+    @objc open func execute(completion: ((NSError?) -> ())? = nil) {
+
         let usingIOS9 = ProcessInfo().isOperatingSystemAtLeast(OperatingSystemVersion(majorVersion: 9, minorVersion: 0, patchVersion: 0))
 
         if usingIOS9 {