-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use Files.createTempFile #141
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
48cd142
use Files.createTempFile
isaacbrodsky 54dbd60
Don't always apply POSIX permissions
isaacbrodsky 8ec486b
back out permissions change
isaacbrodsky 51b5e82
Revert "back out permissions change"
isaacbrodsky 0d911cb
pin back windows
isaacbrodsky 9cd7798
add slack alert & cron
isaacbrodsky 70131c8
broken dockcross tag
isaacbrodsky cdb2863
docker rmi
isaacbrodsky 5de2234
build only specific artifact per test
isaacbrodsky f60d5ba
fix
isaacbrodsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| name: slack-alert | ||
|
|
||
| on: | ||
| workflow_run: | ||
| workflows: [tests] | ||
| types: [completed] | ||
|
|
||
| jobs: | ||
| on-failure: | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.event.workflow_run.conclusion == 'failure' }} | ||
| steps: | ||
| - name: Send Slack Alert | ||
| id: slack | ||
| uses: slackapi/[email protected] | ||
| with: | ||
| payload: | | ||
| Github Actions ${{ github.event.workflow_run.conclusion }} | ||
| Repo: ${{github.event.workflow_run.repository.name }} | ||
| Workflow URL: ${{ github.event.workflow_run.html_url }} | ||
| env: | ||
| SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,9 @@ on: | |
| branches: [master, stable-*] | ||
| pull_request: | ||
| branches: [master, stable-*] | ||
| schedule: | ||
| # Every Sunday, rerun | ||
| - cron: "0 12 * * 0" | ||
|
|
||
| jobs: | ||
| tests: | ||
|
|
@@ -64,7 +67,7 @@ jobs: | |
| os: [ubuntu-latest] | ||
| java-distribution: [adopt] | ||
| java-version: [17] | ||
| dockcross-tag: ["20220906-e88a3ce", "20230116-670f7f7"] | ||
| dockcross-tag: ["20230116-670f7f7", "20240529-0dade71", "latest"] | ||
|
|
||
| steps: | ||
| - uses: actions/[email protected] | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this re-run? What would the test suite catch when re-run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like it's often my experience that the CI process for this repo turns out to have some problem when I go to make a change here, and I'd rather be alerted to that proactively rather than when trying to fix something else. Perhaps the CI issues encountered here are indeed not something that would be usefully caught by this; if that's the case then maybe we don't need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. There definitely seems to be some flakiness involving the docker images. I wonder if it would make more sense to pull the
Dockerfileinto the repo and have the test suite build its own docker image to then run? I guess that would depend on how long it takes to build the image.