use Files.createTempFile #141
Merged
+87
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build #383Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build #384Details
💛 - Coveralls |
This reverts commit 8ec486b.
Pull Request Test Coverage Report for Build #385Details
💛 - Coveralls |
|
The Windows build seems to be failing because: This seems to be a CI / Github Actions issue rather than related to any change in this PR. edit: Not sure if this is at all related: actions/runner-images#10004 Reverting to windows-2019 fixes for me, which does not seem like the same as what's described there. Maybe the 2019 image has already been fixed. |
Pull Request Test Coverage Report for Build #386Details
💛 - Coveralls |
dfellis
approved these changes
Jun 7, 2024
dfellis
reviewed
Jun 7, 2024
Comment on lines
+8
to
+10
| schedule: | ||
| # Every Sunday, rerun | ||
| - cron: "0 12 * * 0" |
There was a problem hiding this comment.
Why this re-run? What would the test suite catch when re-run?
There was a problem hiding this comment.
I feel like it's often my experience that the CI process for this repo turns out to have some problem when I go to make a change here, and I'd rather be alerted to that proactively rather than when trying to fix something else. Perhaps the CI issues encountered here are indeed not something that would be usefully caught by this; if that's the case then maybe we don't need it.
There was a problem hiding this comment.
I see. There definitely seems to be some flakiness involving the docker images. I wonder if it would make more sense to pull the Dockerfile into the repo and have the test suite build its own docker image to then run? I guess that would depend on how long it takes to build the image.
Pull Request Test Coverage Report for Build #387Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build #388Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build #389Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build #390Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140, using
Files.createTempFileis preferable since it will have more restrictive permissions by default. I don't think we can rely on the file being only owner-writable since that is not in the Javadoc. From what I understand, Posix permissions will cause an exception if not supported by the OS, thus we have to check the OS.