Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Completable support to fully use as() #191

Merged
merged 4 commits into from
Apr 4, 2018
Merged

Migrate Completable support to fully use as() #191

merged 4 commits into from
Apr 4, 2018

Conversation

atexannamedbob
Copy link
Contributor

@atexannamedbob atexannamedbob commented Apr 3, 2018 •
edited
Loading

This is the CompletableConverter/CompletableScoper step of #188.
Converting to the new AutoDisposeCompletable and changes AutoDispose to utilize the new AutoDisposeCompletable.

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ZacSweers
ZacSweers reviewed Apr 3, 2018
View reviewed changes
Copy link
Collaborator

@ZacSweers ZacSweers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! Can you make the existing CompletableScoper just delegate to AutoDispose.autoDisposable APIs as part of this?

autodispose/src/main/java/com/uber/autodispose/AutoDisposeCompletable.java Outdated
import io.reactivex.CompletableObserver;
import io.reactivex.Maybe;

class AutoDisposeCompletable extends Completable {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this final

autodispose/src/main/java/com/uber/autodispose/AutoDisposeCompletable.java Outdated
@@ -0,0 +1,37 @@
/*
* Copyright (c) 2017. Uber Technologies
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2018

@ZacSweers ZacSweers changed the title Oren/completeable converter Migrate Completable support to fully use as() Apr 3, 2018
ZacSweers
ZacSweers approved these changes Apr 4, 2018
View reviewed changes
Copy link
Collaborator

@ZacSweers ZacSweers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ZacSweers ZacSweers merged commit 4ddff19 into uber:master Apr 4, 2018
@atexannamedbob atexannamedbob deleted the oren/completeableConverter branch April 4, 2018 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZacSweers ZacSweers ZacSweers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atexannamedbob @CLAassistant @ZacSweers