-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor converters to be the native implementation, make old to() APIs delegate to them. #188
Comments
I'll do one of these initially to set a guideline, then try to leave the rest up for some contributors (I know there's a few people interested) |
First one is up in #189. Once that's merged, others should feel free to claim remaining ones |
First one is down and stencil is in place. @VisheshVadhera if you could just pick one to start, want to leave the rest for others to pick up if interested :) |
I'll pick SingleObserver.
…On Wed, Mar 28, 2018, 4:04 AM Zac Sweers ***@***.***> wrote:
First one is down and stencil is in place. @VisheshVadhera
<https://github.com/VisheshVadhera> if you could just pick one to start,
want to leave the rest for others to pick up if interested :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#188 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD1DELp29IItkQVQ7-gk6c3Ho9kEevMMks5tir6NgaJpZM4S8Khz>
.
|
@hzsweers @VisheshVadhera |
I'm going to move forward with this so we can isolate the next release around it. @VisheshVadhera I'll do SingleObserver last in case you have time to come around to it, but going to do this in the next few days |
@hzsweers Sounds good. I'll open the PR for SingleObserver tonight! |
This is done now |
So currently, every
as()
-based converter API just wraps the oldto()
-based scoper APIs. This works, but in 1.0 we're going to want to remove the oldto()
based APIs, so as an intermediary let's flip this in 0.8.0. This release'll be a non-API changing release, and totally just flip these internals as an incremental update.These can/should be done incrementally, and should be modeled after parallelflowable's implementation. It's ok if the scopers are a bit verbose in the meantime or even duplicated functionality. The main goal here is to get the
as()
APIs fully migrated so that 1.0 is just removing the old scopers. No tests or extension artifacts (android, rxlifecycle) should be changed in this process to ensure the public API is not changing.ObservableConverter
/ObservableScoper
SingleConverter
/SingleScoper
MaybeConverter
/MaybeScoper
CompletableConverter
/CompletableScoper
FlowableConverter
/FlowableScoper
The text was updated successfully, but these errors were encountered: