Bump rufus-scheduler from 3.7.0 to 3.8.0 #2434
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [rufus-scheduler](https://github.com/jmettraux/rufus-scheduler) from 3.7.0 to 3.8.0. - [Release notes](https://github.com/jmettraux/rufus-scheduler/releases) - [Changelog](https://github.com/jmettraux/rufus-scheduler/blob/master/CHANGELOG.md) - [Commits](jmettraux/rufus-scheduler@v3.7.0...v3.8.0) --- updated-dependencies: - dependency-name: rufus-scheduler dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
requested review from
ConnorSheremeta,
lagoan,
murny and
pgwillia
as code owners
| @@ -42,7 +42,7 @@ gem 'sidekiq', '~> 5.2' | |||
| gem 'sidekiq-unique-jobs', '~> 7.0' | |||
| gem 'sinatra', '~> 2.1.0' # used by sidekiq/web | |||
| # Sidekiq cron jobs | |||
| gem 'rufus-scheduler', '3.7.0' # https://github.com/ondrejbartas/sidekiq-cron/issues/199 | |||
| gem 'rufus-scheduler', '3.8.0' # https://github.com/ondrejbartas/sidekiq-cron/issues/199 | |||
There was a problem hiding this comment.
@murny the issue mentioned looks closed to me and we've bumped sidekiq-cron beyond 1.0. Is it sane to remove the comment?
There was a problem hiding this comment.
I think it might even make sense to remove this dependency. In version 1.0 of sidekiq-cron they changed to
use fugit instead of rufus-scheduler - API of cron didn't change (rufus scheduler is using fugit)
There was a problem hiding this comment.
Yeah looks like we can completely drop this since we are on v1.2 of sidekiq-cron which no longer uses this gem.
Does make me a bit nervous we jumped to a major version like this with no real testing (admittily changes to this gem seem very minor: https://github.com/ondrejbartas/sidekiq-cron/blob/master/Changes.md )? I'll add a note to do some through testing of this gem while we look at getting on Sidekiq v6 on this issue: #2189
|
Looks like rufus-scheduler is no longer a dependency, so this is no longer needed. |
dependabot
bot
deleted the
dependabot/bundler/integration/rufus-scheduler-3.8.0
branch
Bumps rufus-scheduler from 3.7.0 to 3.8.0.
Changelog
Sourced from rufus-scheduler's changelog.
Commits
e79d068Release 3.8.01724bbdModernize readme2dbd354Document Job#source_locationef2f113Use wait_until in scheduler specfe4c9bfLoosen spec for GitHub Actionscac394b20214b62df1Prepare 3.8.0c3229c3Migrate to GitHub actions82585eeAdd spec for #source_location with kla/obj, gh-322c9e57e6Add Job#source_location to default on_error gh-322Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)