Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Sidekiq to version 6.x #2189

Closed
murny opened this issue Feb 19, 2021 · 6 comments
Closed

Upgrade Sidekiq to version 6.x #2189

murny opened this issue Feb 19, 2021 · 6 comments
Assignees

Comments

@murny
Copy link
Contributor

murny commented Feb 19, 2021

We currently have sidekiq pinned on v5.X. There appears to be some breaking changes and cleanup to get us on this version.

Should also make sure existing add-on gems like sidekiq-cron and sidekiq-unique-jobs are still working correctly on this new version!

Here's some more info:
#1279

@pgwillia
Copy link
Member

consider require 'sidekiq_unique_jobs/web' in routes.rb

@pgwillia pgwillia self-assigned this Feb 3, 2022
@pgwillia
Copy link
Member

pgwillia commented Feb 7, 2022

  • WARN: DEPRECATION WARNING: Initialization autoloaded the constants ApplicationJob, EmbargoExpiryJob, GarbageCollectBlobsJob, and RemoveInactiveDraftsJob.

Being able to do this is deprecated. Autoloading during initialization is going
to be an error condition in future versions of Rails.

Reloading does not reboot the application, and therefore code executed during
initialization does not run again. So, if you reload ApplicationJob, for example,
the expected changes won't be reflected in that stale Class object.

These autoloaded constants have been unloaded.

In order to autoload safely at boot time, please wrap your code in a reloader
callback this way:

Rails.application.reloader.to_prepare do
  # Autoload classes and modules needed at boot time here.
end

That block runs when the application boots, and every time there is a reload.
For historical reasons, it may run twice, so it has to be idempotent.

Check the "Autoloading and Reloading Constants" guide to learn more about how
Rails autoloads and reloads.
(called from <top (required)> at /home/pjenkins/Code/ualbertalib/jupiter/config/environment.rb:5)

@pgwillia
Copy link
Member

pgwillia commented Feb 7, 2022

  • Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.
redis.pipelined do
  redis.get("key")
end

should be replaced by

redis.pipelined do |pipeline|
  pipeline.get("key")
end

Not something we can fix but will be fixed in future release
sidekiq-cron/sidekiq-cron#310

@pgwillia
Copy link
Member

pgwillia commented Feb 7, 2022

  • Redis.current= is deprecated and will be removed in 5.0.

called from:

  • jupiter/config/initializers/redis.rb:1
  • jupiter/app/models/jupiter_core/depositable.rb:163

@pgwillia
Copy link
Member

pgwillia commented Feb 7, 2022

  • logging changed

@pgwillia
Copy link
Member

In production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants