Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to sbt-typelevel-ci-release #522

Merged
merged 5 commits into from
Mar 6, 2022
Merged

Migrate to sbt-typelevel-ci-release #522

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5459e94
Migrate to sbt-typelevel
armanbilge Mar 4, 2022
50498c6
Mima configuring
armanbilge Mar 5, 2022
30cabc4
Bump base ver to 2.0, build tweaks
armanbilge Mar 6, 2022
bcdc0aa
Poke ci
armanbilge Mar 6, 2022
51595bf
Fix broken test
armanbilge Mar 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shared/src/test/scala/squants/space/VolumeSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ class VolumeSpec extends AnyFlatSpec with Matchers {
}

it should "return Length when cube rooted" in {
CubicMeters(27).cubeRoot should be(Meters(3))
CubicMeters(64).cubeRoot should be(Meters(4))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy fix

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally you could choose the number type to have exact calculations but squants only supports doubles

}

behavior of "VolumeConversions"
Expand Down