Migrate to sbt-typelevel-ci-release #522
Conversation
|
I'm pretty sure binary compatibility has been broken |
|
👍 that's easy enough :) Btw, if you've been following the discussion, we need to remove the repo secrets from squants and also spire, thanks! |
|
Yes go ahead, or I can do it if I have the permission |
|
I don't have permissions, so it will have to be you :) |
|
Native fails with this: |
|
It fails locally for me too ... were you not running this test before? |
|
Ah, you were only compiling native but not testing. squants/.github/workflows/scala.yml Line 18 in 1a8f608 |
|
I think it wasn't possible to compile to native back then, maybe it is now |
|
Ok, I removed the secrets from both spire an squants |
| CubicMeters(27).cubeRoot should be(Meters(3)) | ||
| CubicMeters(64).cubeRoot should be(Meters(4)) |
There was a problem hiding this comment.
Ideally you could choose the number type to have exact calculations but squants only supports doubles
|
Good to go, but you will need to remove the old status check. |
So the tricky thing about this is change is it seems that MiMa is enabled for the first time in this project, and there are many many issues.
Apparently master has already broken binary-compatibility compared to the latest release 1.8.3 due to the changes in #509. This is not considering the 100+ MiMa binary issues if we compare against 1.0.0 :)
One easy strategy may be to declare a clean slate: your next version should be 2.0.0 since it's binary-breaking, and from then on you will preserve binary compatibility (or bump major version again).
WDYT?