Upgrade to Scala.js 1.0.0-M6. #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow to later upgrade to Scala.js 1.0.0-M6.
|
Review by @ashawley? Don't hesitate to tell me if the coding style is off. I usually look around in the repo to find out the proper coding style, but I didn't have much time to dedicate to this today. |
ashawley
reviewed
Feb 27, 2019
| libraryDependencies += "org.scala-js" %% "scalajs-test-interface" % scalaJSVersion, | ||
| // because Scala.js deprecated TestUtils but we haven't worked around that yet, | ||
| // see https://github.com/rickynils/scalacheck/pull/435#issuecomment-430405390 | ||
| scalacOptions ~= (_ filterNot (_ == "-Xfatal-warnings")) |
There was a problem hiding this comment.
If there are no deprecation warnings or warnings of any type in Platform.scala, then sure, -Xfatal-warnings can be re-enabled.
There was a problem hiding this comment.
Yup, there are no warnings of any kind anymore, thanks to this change. :)
ashawley
approved these changes
Feb 27, 2019
|
LGTM. If the build is green, I have no objections. |
|
Yeah, the CI is green :D |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmission of #459, with a first commit not to use the deprecated
TestUtilsanymore.