Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scalajs 1.0.0-M6 #459

Closed
wants to merge 1 commit into from

Conversation

ashawley
Copy link
Contributor

Fixes the 2.13-M5 build for Scalajs:

[warn] 	module not found: org.scala-js#scalajs-library_2.13.0-M5;1.0.0-M3
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::          UNRESOLVED DEPENDENCIES         ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: org.scala-js#scalajs-library_2.13.0-M5;1.0.0-M3: not found
[warn] 	:: org.scala-js#scalajs-test-interface_2.13.0-M5;1.0.0-M3: not found
[warn] 	:: org.scala-js#scalajs-compiler_2.13.0-M5;1.0.0-M3: not found
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 
[warn] 	Note: Unresolved dependencies path:
[warn] 		org.scala-js:scalajs-library_2.13.0-M5:1.0.0-M3
[warn] 		 ((org.scalajs.sbtplugin.ScalaJSPluginInternal.scalaJSProjectBaseSettings)
[warn] 		  ScalaJSPluginInternal.scala#L474)
[warn] 		  +- org.scalacheck:scalacheck_sjs1.0.0-M3_2.13.0-M5:1.14.1-1b6f328-SNAPSHOT
[warn] 		org.scala-js:scalajs-test-interface_2.13.0-M5:1.0.0-M3
[warn] 		 ((org.scalajs.sbtplugin.ScalaJSPluginInternal.scalaJSProjectBaseSettings)
[warn] 		  ScalaJSPluginInternal.scala#L474)
[warn] 		  +- org.scalacheck:scalacheck_sjs1.0.0-M3_2.13.0-M5:1.14.1-1b6f328-SNAPSHOT
[warn] 		org.scala-js:scalajs-compiler_2.13.0-M5:1.0.0-M3 (Defaults.scala#L3320)
[warn] 		  +- org.scalacheck:scalacheck_sjs1.0.0-M3_2.13.0-M5:1.14.1-1b6f328-SNAPSHOT
[error] sbt.librarymanagement.ResolveException: unresolved dependency: 
[error]  org.scala-js#scalajs-library_2.13.0-M5;1.0.0-M3: not found
[error] unresolved dependency: org.scala-js#scalajs-test-interface_2.13.0-M5;1.0.0-M3: not found
[error] unresolved dependency: org.scala-js#scalajs-compiler_2.13.0-M5;1.0.0-M3: not found
[error] (js / update) sbt.librarymanagement.ResolveException: unresolved dependency:
[error]   org.scala-js#scalajs-library_2.13.0-M5;1.0.0-M3: not found
[error] unresolved dependency: org.scala-js#scalajs-test-interface_2.13.0-M5;1.0.0-M3: not found
[error] unresolved dependency: org.scala-js#scalajs-compiler_2.13.0-M5;1.0.0-M3: not found

@ashawley
Copy link
Contributor Author

Travis error:

[error] scalacheck/js/src/main/scala/org/scalacheck/Platform.scala:25:17: 
[error] object testinterface is not a member of package org.scalajs
[error]     org.scalajs.testinterface.TestUtils.loadModule(name, loader)
[error]                 ^

@ashawley
Copy link
Contributor Author

The notes for 1.0.0.-M6 say,

org.scalajs.testinterface.TestUtils was removed (it was deprecated in 0.6.25); use scala.scalajs.reflect.Reflect or portable-scala-reflect instead.

@ashawley
Copy link
Contributor Author

@sjrd Can you suggest a migration path here?

@sjrd
Copy link
Contributor

sjrd commented Feb 27, 2019

As the release notes say, use scala.scalajs.reflect.Reflect instead. The API of Reflect is tiny; it's supposed to be straightforward. Do you need any specific guidance?

@ashawley
Copy link
Contributor Author

@sjrd I was going to update to 1.0.0-M6, but there isn't a portable-scala-reflect artifact published for 1.0.0-M6.

@sjrd
Copy link
Contributor

sjrd commented Feb 27, 2019

Since ScalaCheck already uses a JS-specific Platform.scala for reflective operations, you can directly use scala.scalajs.reflect.Reflect from there, without going through portable-scala-reflect. That will be easier.

@ashawley
Copy link
Contributor Author

Ah, ok. This is more effort than I expected, then. I have to task switch, so I'll close to let someone else pick it up.

@ashawley ashawley closed this Feb 27, 2019
@ashawley ashawley deleted the scalajs_1.0.0-M6 branch August 8, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants