Form.changed_data is not callable fixes #148 #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Aug 29, 2019
django-stubs/forms/forms.pyi
Outdated
| @@ -29,6 +29,7 @@ class BaseForm: | |||
| fields: Dict[str, Any] = ... | |||
| renderer: BaseRenderer = ... | |||
| cleaned_data: Any = ... | |||
| changed_data: List[str]: ... | |||
There was a problem hiding this comment.
Can we make it a @propery? I guess it is the closest match.
There was a problem hiding this comment.
Oh good idea, I changed it 👍
sobolevn
approved these changes
Aug 30, 2019
|
Thanks! |
|
@sobolevn Thanks for merging! When will the next tag be released with this change? |
|
Sorry, we don't have any release schedule yet. Can you use @mkurnikov can you please help us here? |
voidus
pushed a commit
to voidus/django-stubs
that referenced
this pull request
Apr 23, 2024
Hello, this PR actually makes two changes: - add the missing `EmptyFieldListFilter`. - fix the model `Index` class which also accepts positional parameters. I am not sure if this is the right way to contribute to this repository. - Is it ok to submit both changes in a single PR? - How can I be sure everything is working fine? (a.k.a. tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to annotate references to
changed_dataI noticed that mypy suggests its type should beCallable[[BaseForm], List[str]]but since it's an@cached_propertyit is not callable, so it should beList[str].