Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form changed_data should not be callable #148

Closed
jaredlockhart opened this issue Aug 29, 2019 · 0 comments
Closed

Form changed_data should not be callable #148

jaredlockhart opened this issue Aug 29, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@jaredlockhart
Copy link
Contributor

The form stubs have changed_data marked as a Callable[[], List[str]], but it's not callable, it's a property, so I think it should just be List[str]
jaredlockhart added a commit to jaredlockhart/django-stubs that referenced this issue Aug 29, 2019
@jaredlockhart
Form.changed_data is not callable fixes typeddjango#148
7150d25
@sobolevn sobolevn added the bug Something isn't working label Aug 29, 2019
jaredlockhart added a commit to jaredlockhart/django-stubs that referenced this issue Aug 29, 2019
@jaredlockhart
Add property to forms.changed_data fixes typeddjango#148
2992d30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaredlockhart @sobolevn