Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow int, bool for data argument in test.client.Client.get() #1345

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Allow int, bool for data argument in test.client.Client.get() #1345

merged 1 commit into from
Jan 26, 2023

Conversation

nils-van-zuijlen
Copy link
Contributor

Related issues

Closes #1327

@intgr intgr mentioned this pull request Jan 25, 2023
Closed
@intgr
Copy link
Collaborator

intgr commented Jan 25, 2023 •
edited
Loading

Looks like you forgot the changes for _GetDataType for the Client.get method :)

btw is bool allowed now as well implicitly?

@intgr intgr self-assigned this Jan 25, 2023
@intgr
Copy link
Collaborator

intgr commented Jan 26, 2023

Ping @nils-van-zuijlen

intgr
intgr approved these changes Jan 26, 2023
View reviewed changes
Copy link
Collaborator

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Waiting for CI.

@intgr
Copy link
Collaborator

intgr commented Jan 26, 2023 •
edited
Loading

I verified that bool is indeed implicitly accepted, since it's a subtype of int in Python (for awkward historical reasons).

@intgr intgr changed the title Allow int for data argument in test.client.Client.get() Allow int, bool for data argument in test.client.Client.get() Jan 26, 2023
@intgr intgr mentioned this pull request Jan 26, 2023
Closed
@intgr intgr merged commit 2ddd420 into typeddjango:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intgr intgr intgr approved these changes

Assignees

@intgr intgr

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recent changes to test.client.Client.get() do not accept valid data types
2 participants
@nils-van-zuijlen @intgr